revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-19 16:58:48 +02:00
Code Issues Releases Wiki Activity

Allow "!accept" to be enabled through configuration

Browse source 
Summary: For reasons explained in the config I've omitted this from the default
action set, but it's trivial to support it. See D916.

Test Plan: Commented on a revision, was informed I could "!accept" in the email.
Used "!accept" to accept the revision.

Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran

Reviewed By: Makinde

CC: aran, Makinde

Differential Revision: 928
This commit is contained in:
epriestley 2011-09-14 08:11:05 -07:00
parent 9215d330ad
commit a42f116749
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
conf/default.conf.php
View file

@ -522,6 +522,13 @@ return array(
'differential.field-selector' => 'DifferentialDefaultFieldSelector', 'differential.field-selector' => 'DifferentialDefaultFieldSelector',
// If you set this to true, users can "!accept" revisions via email (normally,
// they can take other actions but can not "!accept"). This action is disabled
// by default because email authentication can be configured to be very weak,
// and, socially, email "!accept" is kind of sketchy and implies revisions may
// not actually be receiving thorough review.
'differential.enable-email-accept' => false,
// -- Maniphest ------------------------------------------------------------- // // -- Maniphest ------------------------------------------------------------- //

8
src/applications/differential/replyhandler/DifferentialReplyHandler.php
View file

@ -88,7 +88,7 @@ class DifferentialReplyHandler extends PhabricatorMailReplyHandler {
} }
public function getSupportedCommands() { public function getSupportedCommands() {
return array( $actions = array(
DifferentialAction::ACTION_COMMENT, DifferentialAction::ACTION_COMMENT,
DifferentialAction::ACTION_REJECT, DifferentialAction::ACTION_REJECT,
DifferentialAction::ACTION_ABANDON, DifferentialAction::ACTION_ABANDON,
@ -97,6 +97,12 @@ class DifferentialReplyHandler extends PhabricatorMailReplyHandler {
DifferentialAction::ACTION_RETHINK, DifferentialAction::ACTION_RETHINK,
'unsubscribe', 'unsubscribe',
); );
if (PhabricatorEnv::getEnvConfig('differential.enable-email-accept')) {
$actions[] = DifferentialAction::ACTION_ACCEPT;
}
return $actions;
} }
public function receiveEmail(PhabricatorMetaMTAReceivedMail $mail) { public function receiveEmail(PhabricatorMetaMTAReceivedMail $mail) {