revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Fix a bad parameter read in hovercard

Browse source 
Summary: I broke this at the last second in D17374. `getStrList()` doesn't read arrays. It probably should (more modern analogs do) but don't rock the boat in the leadup to the release cut.

Test Plan: Hovered over a thing, saw a hovercard and no `getStrList()` error in my logs.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17383
This commit is contained in:
epriestley 2017-02-17 16:38:07 -08:00
parent c0cfd4e9aa
commit a439ea7190
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/search/controller/PhabricatorSearchHovercardController.php
View file

@ -9,7 +9,7 @@ final class PhabricatorSearchHovercardController
public function handleRequest(AphrontRequest $request) { public function handleRequest(AphrontRequest $request) {
$viewer = $this->getViewer(); $viewer = $this->getViewer();
$phids = $request->getStrList('phids'); $phids = $request->getArr('phids');
// If object names are provided, look them up and pretend they were // If object names are provided, look them up and pretend they were
// passed as additional PHIDs. This is primarily useful for debugging, // passed as additional PHIDs. This is primarily useful for debugging,