diff --git a/src/applications/herald/adapter/HeraldAdapter.php b/src/applications/herald/adapter/HeraldAdapter.php index b3619b8887..5417958004 100644 --- a/src/applications/herald/adapter/HeraldAdapter.php +++ b/src/applications/herald/adapter/HeraldAdapter.php @@ -194,6 +194,7 @@ abstract class HeraldAdapter { public function getFields() { return array( self::FIELD_ALWAYS, + self::FIELD_RULE, ); } diff --git a/src/applications/herald/adapter/HeraldCommitAdapter.php b/src/applications/herald/adapter/HeraldCommitAdapter.php index cd0e869217..6037cc832b 100644 --- a/src/applications/herald/adapter/HeraldCommitAdapter.php +++ b/src/applications/herald/adapter/HeraldCommitAdapter.php @@ -107,7 +107,6 @@ final class HeraldCommitAdapter extends HeraldAdapter { self::FIELD_DIFF_ADDED_CONTENT, self::FIELD_DIFF_REMOVED_CONTENT, self::FIELD_DIFF_ENORMOUS, - self::FIELD_RULE, self::FIELD_AFFECTED_PACKAGE, self::FIELD_AFFECTED_PACKAGE_OWNER, self::FIELD_NEED_AUDIT_FOR_PACKAGE, diff --git a/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php b/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php index 92f18b876a..f0994f87a6 100644 --- a/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php +++ b/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php @@ -69,10 +69,9 @@ final class HeraldDifferentialRevisionAdapter extends HeraldAdapter { self::FIELD_DIFF_CONTENT, self::FIELD_DIFF_ADDED_CONTENT, self::FIELD_DIFF_REMOVED_CONTENT, - self::FIELD_RULE, self::FIELD_AFFECTED_PACKAGE, self::FIELD_AFFECTED_PACKAGE_OWNER, - self::FIELD_OBJECT_IS_NEW, + self::FIELD_IS_NEW_OBJECT, ), parent::getFields()); } diff --git a/src/applications/herald/adapter/HeraldPholioMockAdapter.php b/src/applications/herald/adapter/HeraldPholioMockAdapter.php index ea897ef189..a49eb98387 100644 --- a/src/applications/herald/adapter/HeraldPholioMockAdapter.php +++ b/src/applications/herald/adapter/HeraldPholioMockAdapter.php @@ -59,7 +59,7 @@ final class HeraldPholioMockAdapter extends HeraldAdapter { self::FIELD_BODY, self::FIELD_AUTHOR, self::FIELD_CC, - self::FIELD_OBJECT_IS_NEW, + self::FIELD_IS_NEW_OBJECT, ), parent::getFields()); } diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php index 57dbda5ca3..81aa6125ba 100644 --- a/src/applications/herald/storage/HeraldRule.php +++ b/src/applications/herald/storage/HeraldRule.php @@ -17,7 +17,7 @@ final class HeraldRule extends HeraldDAO protected $isDisabled = 0; protected $triggerObjectPHID; - protected $configVersion = 29; + protected $configVersion = 30; // phids for which this rule has been applied private $ruleApplied = self::ATTACHABLE;