revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Use "-dispose background" to improve reassembly of GIFs with transparency

Browse source 
Summary:
Fixes T5741. We break GIFs apart with "-coalesce" which completely rasterizes each frame, but stitch them back together without specifying "-dispose".

This produces the default "-dispose none" behavior, which causes GIF frames to "pile up" if they contain transparency.

Instead, use "-dispose background" so that the previous frame is erased before each new frame is drawn.

Test Plan: See T5741 for additional details.

Maniphest Tasks: T5741

Differential Revision: https://secure.phabricator.com/D19214
This commit is contained in:
epriestley 2018-03-13 09:04:15 -07:00
parent 598d0c04e7
commit a4a390fe2d
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/applications/macro/engine/PhabricatorMemeEngine.php
View file

@ -236,7 +236,10 @@ final class PhabricatorMemeEngine extends Phobject {
Filesystem::writeFile($output_name, $memed_frame_data);
}
$future = new ExecFuture('convert -loop 0 %Ls %s', $output_files, $output);
$future = new ExecFuture(
'convert -dispose background -loop 0 %Ls %s',
$output_files,
$output);
$future->setTimeout(10)->resolvex();
return Filesystem::readFile($output);
@ -297,6 +300,9 @@ final class PhabricatorMemeEngine extends Phobject {
$font_max = 72;
$font_min = 5;
$margin_x = 16;
$margin_y = 16;
$last = null;
$cursor = floor(($font_max + $font_min) / 2);
$min = $font_min;
@ -321,12 +327,12 @@ final class PhabricatorMemeEngine extends Phobject {
// text extends, for example if it has a "y".
$descend = $box[3];
if ($height > $dim_y) {
if (($height + $margin_y) > $dim_y) {
$all_fit = false;
break;
}
if ($width > $dim_x) {
if (($width + $margin_x) > $dim_x) {
$all_fit = false;
break;
}