revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-31 08:58:20 +01:00
Code Issues Releases Wiki Activity

Conpherence - only validate **new** participants when validating TYPE_PARTICIPANT transactions

Browse source 
Summary: Fixes T7693.

Test Plan: made a conpherence with my main test account and a throwaway test account. deleted the test account. removed myself from the thread. added myself back to the thread.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7693

Differential Revision: https://secure.phabricator.com/D12306
This commit is contained in:
Bob Trahan 2015-04-06 11:45:43 -07:00
parent 0d63c60848
commit a55fb95bd5
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/conpherence/editor/ConpherenceEditor.php
View file

@ -587,9 +587,9 @@ final class ConpherenceEditor extends PhabricatorApplicationTransactionEditor {
break;
case ConpherenceTransactionType::TYPE_PARTICIPANTS:
foreach ($xactions as $xaction) {
$phids = $this->getPHIDTransactionNewValue(
$xaction,
nonempty($object->getParticipantPHIDs(), array()));
$new_phids = $this->getPHIDTransactionNewValue($xaction, array());
$old_phids = nonempty($object->getParticipantPHIDs(), array());
$phids = array_diff($new_phids, $old_phids);
if (!$phids) {
continue;