1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-26 15:30:58 +01:00

Clean up Project Members UI

Summary:
 - Better spacing for images
 - Remove border
 - White BG on Members page

Test Plan: Review Projects / Project Home / Project Members

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15118
This commit is contained in:
Chad Little 2016-01-26 21:41:24 +00:00 committed by chad
parent 49a44a0b1f
commit a599aed9e2
4 changed files with 21 additions and 9 deletions

View file

@ -7,7 +7,7 @@
*/
return array(
'names' => array(
'core.pkg.css' => 'ab6cb6b8',
'core.pkg.css' => 'bb7485ba',
'core.pkg.js' => '573e6664',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '2de124c9',
@ -141,7 +141,7 @@ return array(
'rsrc/css/phui/phui-info-view.css' => '6d7c3509',
'rsrc/css/phui/phui-list.css' => '9da2aa00',
'rsrc/css/phui/phui-object-box.css' => '407eaf5a',
'rsrc/css/phui/phui-object-item-list-view.css' => 'bbc929b3',
'rsrc/css/phui/phui-object-item-list-view.css' => '0d484a97',
'rsrc/css/phui/phui-pager.css' => 'bea33d23',
'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
'rsrc/css/phui/phui-profile-menu.css' => 'fa814ef9',
@ -817,7 +817,7 @@ return array(
'phui-inline-comment-view-css' => '0fdb3667',
'phui-list-view-css' => '9da2aa00',
'phui-object-box-css' => '407eaf5a',
'phui-object-item-list-view-css' => 'bbc929b3',
'phui-object-item-list-view-css' => '0d484a97',
'phui-pager-css' => 'bea33d23',
'phui-pinboard-view-css' => '2495140e',
'phui-profile-menu-css' => 'fa814ef9',

View file

@ -49,12 +49,14 @@ final class PhabricatorProjectProfileController
->setUser($viewer)
->setProject($project)
->setLimit(5)
->setBackground(PHUIBoxView::GREY)
->setUserPHIDs($project->getMemberPHIDs());
$watcher_list = id(new PhabricatorProjectWatcherListView())
->setUser($viewer)
->setProject($project)
->setLimit(5)
->setBackground(PHUIBoxView::GREY)
->setUserPHIDs($project->getWatcherPHIDs());
$nav = $this->getProfileMenu();

View file

@ -5,6 +5,7 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
private $project;
private $userPHIDs;
private $limit;
private $background;
public function setProject(PhabricatorProject $project) {
$this->project = $project;
@ -33,6 +34,11 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
return $this->limit;
}
public function setBackground($color) {
$this->background = $color;
return $this;
}
abstract protected function canEditList();
abstract protected function getNoDataString();
abstract protected function getRemoveURI($phid);
@ -80,7 +86,7 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
->setImageURI($handle->getImageURI());
$icon = id(new PHUIIconView())
->setIconFont($handle->getIcon().' grey');
->setIconFont($handle->getIcon().' lightbluetext');
$subtitle = $handle->getSubtitle();
@ -125,10 +131,15 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
->setHref("/project/members/{$id}/"));
}
return id(new PHUIObjectBoxView())
$box = id(new PHUIObjectBoxView())
->setHeader($header)
->setObjectList($list)
->setBackground(PHUIBoxView::GREY);
->setObjectList($list);
if ($this->background) {
$box->setBackground($this->background);
}
return $box;
}
}

View file

@ -735,10 +735,9 @@ ul.phui-object-item-list-view .phui-object-item-selected
.phui-object-item-image {
width: 40px;
height: 40px;
box-shadow: inset 0 0 0 1px rgba(55,55,55,.15);
border-radius: 3px;
background-size: 100%;
margin: 6px;
margin: 8px 6px;
position: absolute;
}