revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Add path support to differential.query

Browse source 
Summary:
Allows clients to select open differential revisions that
affect a set of paths.

Test Plan:
http://phabricator.mkedia.dev2975.facebook.com/conduit/method/differential.query/ with

paths: [["E", "tfb/trunk/www/html/intern/css/tabloid"]]
status: "status-open"

(internal facebook repo, obvi)

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: vrana, aran, Korvin

Differential Revision: https://secure.phabricator.com/D2788
This commit is contained in:
mkedia 2012-06-18 17:43:22 -07:00
parent 45a3421e9b
commit a5b5128be9
1 changed files with 39 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
src/applications/conduit/method/differential/ConduitAPI_differential_query_Method.php
View file

@ -48,9 +48,7 @@ final class ConduitAPI_differential_query_Method
'authors' => 'optional list<phid>', 'authors' => 'optional list<phid>',
'ccs' => 'optional list<phid>', 'ccs' => 'optional list<phid>',
'reviewers' => 'optional list<phid>', 'reviewers' => 'optional list<phid>',
// TODO: Implement this, it needs to accept a repository ID in addition 'paths' => 'optional list<pair<callsign, path>>',
// to a path so the signature needs to be a little more complicated.
// 'paths' => 'optional list<pair<...>>',
'commitHashes' => 'optional list<pair<enum<'. 'commitHashes' => 'optional list<pair<enum<'.
$hash_types.'>, string>>', $hash_types.'>, string>>',
'status' => 'optional enum<'.$status_types.'>', 'status' => 'optional enum<'.$status_types.'>',
@ -82,6 +80,7 @@ final class ConduitAPI_differential_query_Method
$reviewers = $request->getValue('reviewers'); $reviewers = $request->getValue('reviewers');
$status = $request->getValue('status'); $status = $request->getValue('status');
$order = $request->getValue('order'); $order = $request->getValue('order');
$path_pairs = $request->getValue('paths');
$commit_hashes = $request->getValue('commitHashes'); $commit_hashes = $request->getValue('commitHashes');
$limit = $request->getValue('limit'); $limit = $request->getValue('limit');
$offset = $request->getValue('offset'); $offset = $request->getValue('offset');
@ -102,17 +101,47 @@ final class ConduitAPI_differential_query_Method
if ($reviewers) { if ($reviewers) {
$query->withReviewers($reviewers); $query->withReviewers($reviewers);
} }
/* TODO: Implement.
$paths = $request->getValue('paths');
if ($paths) {
foreach ($paths as $path) {
// (Lookup the repository IDs.) if ($path_pairs) {
$paths = array();
foreach ($path_pairs as $pair) {
list($callsign, $path) = $pair;
$paths[] = $path;
}
$query->withPath($repository_id, $path); $path_map = id(new DiffusionPathIDQuery($paths))->loadPathIDs();
if (count($path_map) != count($paths)) {
$unknown_paths = array();
foreach ($paths as $p) {
if (!idx($path_map, $p)) {
$unknown_paths[] = $p;
}
}
throw id(new ConduitException('ERR-INVALID-PARAMETER'))
->setErrorDescription(
'Unknown paths: '.implode(', ', $unknown_paths));
}
$repos = array();
foreach ($path_pairs as $pair) {
list($callsign, $path) = $pair;
if (!idx($repos, $callsign)) {
$repos[$callsign] = id(new PhabricatorRepository())->loadOneWhere(
'callsign = %s',
$callsign);
if (!$repos[$callsign]) {
throw id(new ConduitException('ERR-INVALID-PARAMETER'))
->setErrorDescription(
'Unknown repo callsign: '.$callsign);
}
}
$repo = $repos[$callsign];
$query->withPath($repo->getID(), idx($path_map, $path));
} }
} }
*/
if ($commit_hashes) { if ($commit_hashes) {
$hash_types = ArcanistDifferentialRevisionHash::getTypes(); $hash_types = ArcanistDifferentialRevisionHash::getTypes();
foreach ($commit_hashes as $info) { foreach ($commit_hashes as $info) {