revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Fix an issue with BuildLogs and web UI during builds

Browse source 
Summary:
Ref T9123. After recent changes, viewing a live build log from the web UI throws a CSRF exception.

Check `start` ("this object is an active log"), not `live` ("this log is open somewhere").

Test Plan: Will push / etc.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9123

Differential Revision: https://secure.phabricator.com/D14185
This commit is contained in:
epriestley 2015-09-28 19:11:51 -07:00
parent efaa8170c3
commit a5c4177160
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
View file

@ -20,7 +20,7 @@ final class HarbormasterBuildLog extends HarbormasterDAO
const ENCODING_TEXT = 'text'; const ENCODING_TEXT = 'text';
public function __destruct() { public function __destruct() {
if ($this->live) { if ($this->start) {
$this->finalize($this->start); $this->finalize($this->start);
} }
} }