Provide convenience method addTextCrumb() to PhabricatorCrumbsView

Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan:
  - This was mostly automated, then I cleaned up a few unusual sites manually.
  - Bunch of grep / randomly clicking around.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: hach-que, aran

Differential Revision: https://secure.phabricator.com/D7787

src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php

@@ -70,13 +70,8 @@ final class PhabricatorAuthConfirmLinkController
     $dialog->appendChild($form);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Confirm Link'), $panel_uri);
-      id(new PhabricatorCrumbView())
+    $crumbs->addTextCrumb($provider->getProviderName());
-        ->setName(pht('Confirm Link'))
-        ->setHref($panel_uri));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($provider->getProviderName()));
 
     return $this->buildApplicationPage(
       array(

src/applications/auth/controller/PhabricatorAuthLinkController.php

@@ -115,13 +115,8 @@ final class PhabricatorAuthLinkController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Link Account'), $panel_uri);
-      id(new PhabricatorCrumbView())
+    $crumbs->addTextCrumb($provider->getProviderName($name));
-        ->setName(pht('Link Account'))
-        ->setHref($panel_uri));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($provider->getProviderName($name)));
 
     return $this->buildApplicationPage(
       array(

src/applications/auth/controller/PhabricatorAuthLoginController.php

@@ -202,20 +202,12 @@ final class PhabricatorAuthLoginController
     $crumbs = $this->buildApplicationCrumbs();
 
     if ($this->getRequest()->getUser()->isLoggedIn()) {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Link Account'), $provider->getSettingsURI());
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Link Account'))
-          ->setHref($provider->getSettingsURI()));
     } else {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Login'), $this->getApplicationURI('start/'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Login'))
-          ->setHref($this->getApplicationURI('start/')));
     }
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($provider->getProviderName());
-      id(new PhabricatorCrumbView())
-        ->setName($provider->getProviderName()));
 
     return $this->buildApplicationPage(
       array(

src/applications/auth/controller/PhabricatorAuthRegisterController.php

@@ -401,17 +401,11 @@ final class PhabricatorAuthRegisterController
     $crumbs = $this->buildApplicationCrumbs();
 
     if ($is_setup) {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Setup Admin Account'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Setup Admin Account')));
         $title = pht('Welcome to Phabricator');
     } else {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Register'));
-        id(new PhabricatorCrumbView())
+      $crumbs->addTextCrumb($provider->getProviderName());
-          ->setName(pht('Register')));
-      $crumbs->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName($provider->getProviderName()));
         $title = pht('Phabricator Registration');
     }
 

src/applications/auth/controller/PhabricatorAuthStartController.php

@@ -126,9 +126,7 @@ final class PhabricatorAuthStartController
     $login_message = phutil_safe_html($login_message);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Login'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Login')));
 
     return $this->buildApplicationPage(
       array(

src/applications/auth/controller/PhabricatorEmailLoginController.php

@@ -133,9 +133,7 @@ EOBODY;
           ->setError($e_captcha));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Reset Password'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Reset Password')));
 
     $dialog = new AphrontDialogView();
     $dialog->setUser($request->getUser());

src/applications/auth/controller/PhabricatorEmailVerificationController.php

@@ -82,9 +82,7 @@ final class PhabricatorEmailVerificationController
       ->appendChild($content);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Verify Email'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Verify Email')));
 
     return $this->buildApplicationPage(
       array(

src/applications/auth/controller/config/PhabricatorAuthEditController.php

@@ -281,9 +281,7 @@ final class PhabricatorAuthEditController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($crumb);
-      id(new PhabricatorCrumbView())
-        ->setName($crumb));
 
     $xaction_view = null;
     if (!$is_new) {

src/applications/auth/controller/config/PhabricatorAuthListController.php

@@ -86,9 +86,7 @@ final class PhabricatorAuthListController
           pht('Add Authentication Provider'))));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Auth Providers'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Auth Providers')));
 
     $config_name = 'auth.email-domains';
     $config_href = '/config/edit/'.$config_name.'/';

src/applications/auth/controller/config/PhabricatorAuthNewController.php

@@ -87,9 +87,7 @@ final class PhabricatorAuthNewController
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Add Provider'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Add Provider')));
 
     return $this->buildApplicationPage(
       array(

src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php

@@ -23,10 +23,7 @@ final class PhabricatorChatLogChannelListController
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb(pht('Channel List'), $this->getApplicationURI());
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Channel List'))
-          ->setHref($this->getApplicationURI()));
 
     return $this->buildApplicationPage(
       array(

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

@@ -183,10 +183,7 @@ final class PhabricatorChatLogChannelLogController
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb($channel->getChannelName(), $uri);
-        id(new PhabricatorCrumbView())
-          ->setName($channel->getChannelName())
-          ->setHref($uri));
 
     $form = id(new AphrontFormView())
       ->setUser($user)

src/applications/conduit/controller/PhabricatorConduitAPIController.php

@@ -380,15 +380,9 @@ final class PhabricatorConduitAPIController
 
     $method_uri = $this->getApplicationURI('method/'.$method.'/');
 
-    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs = $this->buildApplicationCrumbs()
-    $crumbs
+      ->addTextCrumb($method, $method_uri)
-      ->addCrumb(
+      ->addTextCrumb(pht('Call'));
-        id(new PhabricatorCrumbView())
-          ->setName($method)
-          ->setHref($method_uri))
-      ->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Call')));
 
     return $this->buildApplicationPage(
       array(

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

@@ -116,9 +116,7 @@ final class PhabricatorConduitConsoleController
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($method->getAPIMethodName());
-      id(new PhabricatorCrumbView())
-        ->setName($method->getAPIMethodName()));
 
     return $this->buildApplicationPage(
       array(

src/applications/conduit/controller/PhabricatorConduitLogController.php

@@ -40,9 +40,7 @@ final class PhabricatorConduitLogController
     $table = $this->renderCallTable($calls, $conns);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Call Logs'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Call Logs')));
 
     return $this->buildApplicationPage(
       array(

src/applications/conduit/controller/PhabricatorConduitTokenController.php

@@ -49,9 +49,7 @@ final class PhabricatorConduitTokenController
       ->appendRemarkupInstructions($post_instructions);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Install Certificate'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Install Certificate')));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Certificate Token'))

src/applications/config/controller/PhabricatorConfigAllController.php

@@ -56,9 +56,7 @@ final class PhabricatorConfigAllController
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb($title);
-        id(new PhabricatorCrumbView())
-          ->setName($title));
 
     $panel = new AphrontPanelView();
     $panel->appendChild($table);

src/applications/config/controller/PhabricatorConfigEditController.php

@@ -199,22 +199,13 @@ final class PhabricatorConfigEditController
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Config'), $this->getApplicationURI());
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Config'))
-        ->setHref($this->getApplicationURI()));
 
     if ($group) {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb($group->getName(), $group_uri);
-        id(new PhabricatorCrumbView())
-          ->setName($group->getName())
-          ->setHref($group_uri));
     }
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($this->key, '/config/edit/'.$this->key);
-      id(new PhabricatorCrumbView())
-        ->setName($this->key)
-        ->setHref('/config/edit/'.$this->key));
 
     $xactions = id(new PhabricatorConfigTransactionQuery())
       ->withObjectPHIDs(array($config_entry->getPHID()))

src/applications/config/controller/PhabricatorConfigGroupController.php

@@ -28,14 +28,8 @@ final class PhabricatorConfigGroupController
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb(pht('Config'), $this->getApplicationURI())
-        id(new PhabricatorCrumbView())
+      ->addTextCrumb($options->getName(), $this->getApplicationURI());
-          ->setName(pht('Config'))
-          ->setHref($this->getApplicationURI()))
-      ->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName($options->getName())
-          ->setHref($this->getApplicationURI()));
 
     return $this->buildApplicationPage(
       array(

src/applications/config/controller/PhabricatorConfigIssueListController.php

@@ -30,10 +30,7 @@ final class PhabricatorConfigIssueListController
 
     $crumbs = $this
       ->buildApplicationCrumbs($nav)
-      ->addCrumb(
+      ->addTextCrumb(pht('Setup'), $this->getApplicationURI('issue/'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Setup'))
-          ->setHref($this->getApplicationURI('issue/')));
 
     $nav->setCrumbs($crumbs);
 

src/applications/config/controller/PhabricatorConfigIssueViewController.php

@@ -38,14 +38,8 @@ final class PhabricatorConfigIssueViewController
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb(pht('Setup Issues'), $this->getApplicationURI('issue/'))
-        id(new PhabricatorCrumbView())
+      ->addTextCrumb($title, $request->getRequestURI());
-          ->setName(pht('Setup Issues'))
-          ->setHref($this->getApplicationURI('issue/')))
-      ->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName($title)
-          ->setHref($request->getRequestURI()));
 
     return $this->buildApplicationPage(
       array(

src/applications/config/controller/PhabricatorConfigListController.php

@@ -26,10 +26,7 @@ final class PhabricatorConfigListController
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb(pht('Config'), $this->getApplicationURI());
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Config'))
-          ->setHref($this->getApplicationURI()));
 
     $nav->setCrumbs($crumbs);
 

src/applications/countdown/controller/PhabricatorCountdownEditController.php

@@ -90,18 +90,11 @@ final class PhabricatorCountdownEditController
     $cancel_uri = '/countdown/';
     if ($countdown->getID()) {
       $cancel_uri = '/countdown/'.$countdown->getID().'/';
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb('C'.$countdown->getID(), $cancel_uri);
-        id(new PhabricatorCrumbView())
+      $crumbs->addTextCrumb(pht('Edit'));
-          ->setName('C'.$countdown->getID())
-          ->setHref($cancel_uri));
-      $crumbs->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Edit')));
       $submit_label = pht('Save Changes');
     } else {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Create Countdown'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Create Countdown')));
       $submit_label = pht('Create Countdown');
     }
 

src/applications/countdown/controller/PhabricatorCountdownViewController.php

@@ -36,9 +36,7 @@ final class PhabricatorCountdownViewController
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb("C{$id}");
-        id(new PhabricatorCrumbView())
-          ->setName("C{$id}"));
 
     $header = id(new PHUIHeaderView())
       ->setHeader($title)

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

@@ -211,9 +211,7 @@ final class PhabricatorDaemonConsoleController
     $queued_panel->setNoBackground();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Console'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Console')));
 
     $nav = $this->buildSideNavView();
     $nav->selectFilter('/');

src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php

@@ -29,14 +29,11 @@ final class PhabricatorDaemonLogEventViewController
 
     $daemon_id = $event->getLogID();
 
-    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs = $this->buildApplicationCrumbs()
-    $crumbs->addCrumb(
+      ->addTextCrumb(
-      id(new PhabricatorCrumbView())
+        pht('Daemon %s', $daemon_id),
-        ->setName(pht('Daemon %s', $daemon_id))
+        $this->getApplicationURI("log/{$daemon_id}/"))
-        ->setHref($this->getApplicationURI("log/{$daemon_id}/")));
+      ->addTextCrumb(pht('Event %s', $event->getID()));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Event %s', $event->getID())));
 
 
     return $this->buildApplicationPage(

src/applications/daemon/controller/PhabricatorDaemonLogListController.php

@@ -19,9 +19,7 @@ final class PhabricatorDaemonLogListController
     $daemon_table->setDaemonLogs($logs);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('All Daemons'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('All Daemons')));
 
     $nav = $this->buildSideNavView();
     $nav->selectFilter('log');

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

@@ -26,9 +26,7 @@ final class PhabricatorDaemonLogViewController
       $log->getID());
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Daemon %s', $log->getID()));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Daemon %s', $log->getID())));
 
     $header = id(new PHUIHeaderView())
       ->setHeader($log->getDaemon());

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

@@ -58,9 +58,7 @@ final class PhabricatorWorkerTaskDetailController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title);
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
     return $this->buildApplicationPage(
       array(

src/applications/differential/controller/DifferentialDiffCreateController.php

@@ -88,9 +88,7 @@ final class DifferentialDiffCreateController extends DifferentialController {
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Create Diff'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Create Diff')));
 
     if ($errors) {
       $errors = id(new AphrontErrorView())

src/applications/differential/controller/DifferentialDiffViewController.php

@@ -146,9 +146,7 @@ final class DifferentialDiffViewController extends DifferentialController {
       ->setUser($request->getUser());
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Diff %d', $diff->getID()));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Diff %d', $diff->getID())));
 
     return $this->buildApplicationPage(
       array(

src/applications/differential/controller/DifferentialRevisionEditController.php

@@ -153,16 +153,14 @@ final class DifferentialRevisionEditController extends DifferentialController {
     if ($revision->getID()) {
       if ($diff) {
         $title = pht('Update Differential Revision');
-        $crumbs->addCrumb(
+        $crumbs->addTextCrumb(
-          id(new PhabricatorCrumbView())
+          'D'.$revision->getID(),
-            ->setName('D'.$revision->getID())
+          '/differential/diff/'.$diff->getID().'/');
-            ->setHref('/differential/diff/'.$diff->getID().'/'));
       } else {
         $title = pht('Edit Differential Revision');
-        $crumbs->addCrumb(
+        $crumbs->addTextCrumb(
-          id(new PhabricatorCrumbView())
+          'D'.$revision->getID(),
-            ->setName('D'.$revision->getID())
+          '/D'.$revision->getID());
-            ->setHref('/D'.$revision->getID()));
       }
     } else {
       $title = pht('Create New Differential Revision');
@@ -173,9 +171,7 @@ final class DifferentialRevisionEditController extends DifferentialController {
       ->setFormError($error_view)
       ->setForm($form);
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title);
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
     return $this->buildApplicationPage(
       array(

src/applications/differential/controller/DifferentialRevisionViewController.php

@@ -421,10 +421,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
     );
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($object_id, '/'.$object_id);
-      id(new PhabricatorCrumbView())
-        ->setName($object_id)
-        ->setHref('/'.$object_id));
 
     $prefs = $user->loadPreferences();
 

src/applications/diffusion/controller/DiffusionLintController.php

@@ -139,9 +139,7 @@ final class DiffusionLintController extends DiffusionController {
     if ($this->diffusionRequest) {
       $title[] = $drequest->getCallsign();
     } else {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('All Lint'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('All Lint')));
     }
 
     if ($this->diffusionRequest) {

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

@@ -181,9 +181,7 @@ final class DiffusionRepositoryCreateController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title);
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
     return $this->buildApplicationPage(
       array(

src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php

@@ -59,9 +59,7 @@ final class DiffusionRepositoryEditActionsController
     $content = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Actions'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Actions')));
 
     $title = pht('Edit Actions (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditBasicController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Basics'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Basics')));
 
     $title = pht('Edit %s', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php

@@ -88,9 +88,7 @@ final class DiffusionRepositoryEditBranchesController
     $content = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Branches'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Branches')));
 
     $title = pht('Edit Branches (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditController.php

@@ -11,20 +11,12 @@ abstract class DiffusionRepositoryEditController
       $repo_uri = $this->getRepositoryControllerURI($repository, '');
       $edit_uri = $this->getRepositoryControllerURI($repository, 'edit/');
 
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb('r'.$repository->getCallsign(), $repo_uri);
-        id(new PhabricatorCrumbView())
-          ->setName('r'.$repository->getCallsign())
-          ->setHref($repo_uri));
 
       if ($is_main) {
-        $crumbs->addCrumb(
+        $crumbs->addTextCrumb(pht('Edit Repository'));
-          id(new PhabricatorCrumbView())
-            ->setName(pht('Edit Repository')));
       } else {
-        $crumbs->addCrumb(
+        $crumbs->addTextCrumb(pht('Edit'), $edit_uri);
-          id(new PhabricatorCrumbView())
-            ->setName(pht('Edit'))
-            ->setHref($edit_uri));
       }
     }
 

src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php

@@ -57,9 +57,7 @@ final class DiffusionRepositoryEditEncodingController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Encoding'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Encoding')));
 
     $title = pht('Edit %s', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditHostingController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Hosting'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Hosting')));
 
     $title = pht('Edit Hosting (%s)', $repository->getName());
 
@@ -172,9 +170,7 @@ final class DiffusionRepositoryEditHostingController
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Protocols'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Protocols')));
 
     $title = pht('Edit Protocols (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php

@@ -29,9 +29,7 @@ final class DiffusionRepositoryEditLocalController
     $errors = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Local'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Local')));
 
     $title = pht('Edit %s', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php

@@ -67,9 +67,7 @@ final class DiffusionRepositoryEditPolicyController
     $content = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Policies'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Policies')));
 
     $title = pht('Edit Policies (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php

@@ -70,9 +70,7 @@ final class DiffusionRepositoryEditSubversionController
     $content = array();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Edit Subversion Info'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Subversion Info')));
 
     $title = pht('Edit Subversion Info (%s)', $repository->getName());
 

src/applications/diffusion/controller/DiffusionRepositoryNewController.php

@@ -67,9 +67,7 @@ final class DiffusionRepositoryNewController
           ->addCancelButton($this->getApplicationURI()));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('New Repository'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('New Repository')));
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Create or Import Repository'))

src/applications/diviner/controller/DivinerAtomController.php

@@ -59,18 +59,15 @@ final class DivinerAtomController extends DivinerController {
     $atom = $symbol->getAtom();
     $crumbs = $this->buildApplicationCrumbs();
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(
-      id(new PhabricatorCrumbView())
+      $book->getShortTitle(),
-        ->setName($book->getShortTitle())
+      '/book/'.$book->getName().'/');
-        ->setHref('/book/'.$book->getName().'/'));
 
     $atom_short_title = $atom->getDocblockMetaValue(
       'short',
       $symbol->getTitle());
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($atom_short_title);
-      id(new PhabricatorCrumbView())
-        ->setName($atom_short_title));
 
     $header = id(new PHUIHeaderView())
       ->setHeader($this->renderFullSignature($symbol))

src/applications/diviner/controller/DivinerBookController.php

@@ -27,10 +27,9 @@ final class DivinerBookController extends DivinerController {
 
     $crumbs = $this->buildApplicationCrumbs();
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(
-      id(new PhabricatorCrumbView())
+      $book->getShortTitle(),
-        ->setName($book->getShortTitle())
+      '/book/'.$book->getName().'/');
-        ->setHref('/book/'.$book->getName().'/'));
 
     $header = id(new PHUIHeaderView())
       ->setHeader($book->getTitle())

src/applications/diviner/controller/DivinerLegacyController.php

@@ -43,9 +43,7 @@ final class DivinerLegacyController extends DivinerController {
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Documentation'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Documentation')));
 
     $header = id(new PHUIHeaderView())
       ->setHeader(pht('Documentation'));

src/applications/drydock/controller/DrydockBlueprintEditController.php

@@ -80,12 +80,8 @@ final class DrydockBlueprintEditController extends DrydockController {
 
     $title = pht('Edit Blueprint');
     $header = pht('Edit Blueprint %d', $blueprint->getID());
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Blueprint %d', $blueprint->getID()));
-      id(new PhabricatorCrumbView())
+    $crumbs->addTextCrumb(pht('Edit'));
-        ->setName(pht('Blueprint %d', $blueprint->getID())));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit')));
 
     if ($request->isAjax()) {
       $dialog = id(new AphrontDialogView())

src/applications/drydock/controller/DrydockBlueprintListController.php

@@ -18,10 +18,7 @@ final class DrydockBlueprintListController extends DrydockController {
     $blueprint_list = $this->buildBlueprintListView($blueprints);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title, $request->getRequestURI());
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($request->getRequestURI()));
 
     $crumbs->addAction(
       id(new PHUIListItemView())

src/applications/drydock/controller/DrydockBlueprintViewController.php

@@ -42,9 +42,7 @@ final class DrydockBlueprintViewController extends DrydockController {
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Blueprint %d', $blueprint->getID()));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Blueprint %d', $blueprint->getID())));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)

src/applications/drydock/controller/DrydockLeaseListController.php

@@ -31,10 +31,7 @@ final class DrydockLeaseListController extends DrydockController {
       ));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title, $request->getRequestURI());
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($request->getRequestURI()));
     $nav->setCrumbs($crumbs);
 
     return $this->buildApplicationPage(

src/applications/drydock/controller/DrydockLeaseViewController.php

@@ -40,10 +40,7 @@ final class DrydockLeaseViewController extends DrydockController {
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title, $lease_uri);
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($lease_uri));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)

src/applications/drydock/controller/DrydockLogController.php

@@ -43,10 +43,7 @@ final class DrydockLogController extends DrydockController {
       ));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title, $this->getApplicationURI('/logs/'));
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($this->getApplicationURI('/logs/')));
     $nav->setCrumbs($crumbs);
 
     return $this->buildApplicationPage(

src/applications/drydock/controller/DrydockResourceListController.php

@@ -20,10 +20,7 @@ final class DrydockResourceListController extends DrydockController {
     $resource_list = $this->buildResourceListView($resources);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title, $request->getRequestURI());
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($request->getRequestURI()));
 
     $nav = $this->buildSideNav('resource');
     $nav->setCrumbs($crumbs);

src/applications/drydock/controller/DrydockResourceViewController.php

@@ -49,9 +49,7 @@ final class DrydockResourceViewController extends DrydockController {
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Resource %d', $resource->getID()));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Resource %d', $resource->getID())));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)

src/applications/feed/controller/PhabricatorFeedDetailController.php

@@ -30,9 +30,7 @@ final class PhabricatorFeedDetailController extends PhabricatorFeedController {
     $feed_view = phutil_tag_div('phabricator-feed-frame', $feed_view);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title);
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
 
     return $this->buildApplicationPage(

src/applications/files/controller/PhabricatorFileInfoController.php

@@ -47,10 +47,9 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
     $timeline = $this->buildTransactionView($file, $xactions);
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(
-      id(new PhabricatorCrumbView())
+      'F'.$file->getID(),
-        ->setName('F'.$file->getID())
+      $this->getApplicationURI("/info/{$phid}/"));
-        ->setHref($this->getApplicationURI("/info/{$phid}/")));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header);

src/applications/files/controller/PhabricatorFileUploadController.php

@@ -60,10 +60,7 @@ final class PhabricatorFileUploadController extends PhabricatorFileController {
       ->appendChild($instructions);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Upload'), $request->getRequestURI());
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Upload'))
-        ->setHref($request->getRequestURI()));
 
     $title = pht('Upload File');
 

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

@@ -37,9 +37,7 @@ final class HarbormasterBuildViewController
     $this->buildPropertyLists($box, $build, $actions);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title);
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
     $build_targets = id(new HarbormasterBuildTargetQuery())
       ->setViewer($viewer)

src/applications/harbormaster/controller/HarbormasterBuildableEditController.php

@@ -119,18 +119,11 @@ final class HarbormasterBuildableEditController
 
     $crumbs = $this->buildApplicationCrumbs();
     if ($is_new) {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('New Buildable'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('New Buildable')));
     } else {
       $id = $buildable->getID();
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb("B{$id}", "/B{$id}");
-        id(new PhabricatorCrumbView())
+      $crumbs->addTextCrumb(pht('Edit'));
-          ->setName("B{$id}")
-          ->setHref("/B{$id}"));
-      $crumbs->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Edit')));
     }
 
     return $this->buildApplicationPage(

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

@@ -94,9 +94,7 @@ final class HarbormasterBuildableViewController
     $this->buildPropertyLists($box, $buildable, $actions);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb("B{$id}");
-      id(new PhabricatorCrumbView())
-        ->setName("B{$id}"));
 
     return $this->buildApplicationPage(
       array(

src/applications/harbormaster/controller/HarbormasterPlanController.php

@@ -5,10 +5,9 @@ abstract class HarbormasterPlanController extends PhabricatorController {
   public function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(
-      id(new PhabricatorCrumbView())
+      pht('Build Plans'),
-        ->setName(pht('Build Plans'))
+      $this->getApplicationURI('plan/'));
-        ->setHref($this->getApplicationURI('plan/')));
 
     return $crumbs;
   }

src/applications/harbormaster/controller/HarbormasterPlanEditController.php

@@ -93,18 +93,13 @@ final class HarbormasterPlanEditController
 
     $crumbs = $this->buildApplicationCrumbs();
     if ($is_new) {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('New Build Plan'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('New Build Plan')));
     } else {
       $id = $plan->getID();
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(
-        id(new PhabricatorCrumbView())
+        pht("Plan %d", $id),
-          ->setName(pht("Plan %d", $id))
+        $this->getApplicationURI("plan/{$id}/"));
-          ->setHref($this->getApplicationURI("plan/{$id}/")));
+      $crumbs->addTextCrumb(pht('Edit'));
-      $crumbs->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Edit')));
     }
 
     return $this->buildApplicationPage(

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

@@ -51,9 +51,7 @@ final class HarbormasterPlanViewController
     $this->buildPropertyLists($box, $plan, $actions);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht("Plan %d", $id));
-      id(new PhabricatorCrumbView())
-        ->setName(pht("Plan %d", $id)));
 
     $step_list = $this->buildStepList($plan);
 

src/applications/harbormaster/controller/HarbormasterStepEditController.php

@@ -132,13 +132,10 @@ final class HarbormasterStepEditController
 
     $crumbs = $this->buildApplicationCrumbs();
     $id = $plan->getID();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(
-      id(new PhabricatorCrumbView())
+      pht("Plan %d", $id),
-        ->setName(pht("Plan %d", $id))
+      $this->getApplicationURI("plan/{$id}/"));
-        ->setHref($this->getApplicationURI("plan/{$id}/")));
+    $crumbs->addTextCrumb(pht('Edit Step'));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Step')));
 
     return $this->buildApplicationPage(
       array(

src/applications/herald/controller/HeraldNewController.php

@@ -89,9 +89,7 @@ final class HeraldNewController extends HeraldController {
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb(pht('Create Rule'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Create Rule')));
 
     return $this->buildApplicationPage(
       array(

src/applications/herald/controller/HeraldRuleController.php

@@ -194,9 +194,7 @@ final class HeraldRuleController extends HeraldController {
 
     $crumbs = $this
       ->buildApplicationCrumbs()
-      ->addCrumb(
+      ->addTextCrumb($title);
-        id(new PhabricatorCrumbView())
-          ->setName($title));
 
     return $this->buildApplicationPage(
       array(

src/applications/herald/controller/HeraldRuleEditHistoryController.php

@@ -37,10 +37,9 @@ final class HeraldRuleEditHistoryController extends HeraldController {
 
     $crumbs = $this
       ->buildApplicationCrumbs($can_create = false)
-      ->addCrumb(
+      ->addTextCrumb(
-        id(new PhabricatorCrumbView())
+        pht('Edit History'),
-          ->setName(pht('Edit History'))
+        $this->getApplicationURI('herald/history'));
-          ->setHref($this->getApplicationURI('herald/history')));
 
     $nav = $this->buildSideNavView();
     $nav->selectFilter('history');

src/applications/herald/controller/HeraldRuleViewController.php

@@ -44,9 +44,7 @@ final class HeraldRuleViewController extends HeraldController {
     $id = $rule->getID();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb("H{$id}");
-      id(new PhabricatorCrumbView())
-        ->setName("H{$id}"));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)

src/applications/herald/controller/HeraldTestConsoleController.php

@@ -112,13 +112,10 @@ final class HeraldTestConsoleController extends HeraldController {
       ->setForm($form);
 
     $crumbs = id($this->buildApplicationCrumbs())
-      ->addCrumb(
+      ->addTextCrumb(
-        id(new PhabricatorCrumbView())
+        pht('Transcripts'),
-          ->setName(pht('Transcripts'))
+        $this->getApplicationURI('/transcript/'))
-          ->setHref($this->getApplicationURI('/transcript/')))
+      ->addTextCrumb(pht('Test Console'));
-      ->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Test Console')));
 
     return $this->buildApplicationPage(
       $box,

src/applications/herald/controller/HeraldTranscriptController.php

@@ -97,13 +97,10 @@ final class HeraldTranscriptController extends HeraldController {
     }
 
     $crumbs = id($this->buildApplicationCrumbs())
-      ->addCrumb(
+      ->addTextCrumb(
-        id(new PhabricatorCrumbView())
+        pht('Transcripts'),
-          ->setName(pht('Transcripts'))
+        $this->getApplicationURI('/transcript/'))
-          ->setHref($this->getApplicationURI('/transcript/')))
+      ->addTextCrumb($xscript->getID());
-      ->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName($xscript->getID()));
     $nav->setCrumbs($crumbs);
 
     return $this->buildApplicationPage(

src/applications/herald/controller/HeraldTranscriptListController.php

@@ -72,9 +72,7 @@ final class HeraldTranscriptListController extends HeraldController {
     $nav->appendChild($panel);
 
     $crumbs = id($this->buildApplicationCrumbs())
-      ->addCrumb(
+      ->addTextCrumb(pht('Transcripts'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Transcripts')));
     $nav->setCrumbs($crumbs);
 
     return $this->buildApplicationPage(

src/applications/legalpad/controller/LegalpadDocumentEditController.php

@@ -173,8 +173,7 @@ final class LegalpadDocumentEditController extends LegalpadController {
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($short);
-      id(new PhabricatorCrumbView())->setName($short));
 
 
     $preview = id(new PHUIRemarkupPreviewPanel())

src/applications/legalpad/controller/LegalpadDocumentViewController.php

@@ -81,10 +81,9 @@ final class LegalpadDocumentViewController extends LegalpadController {
 
     $crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(
-      id(new PhabricatorCrumbView())
+      'L'.$document->getID(),
-        ->setName('L'.$document->getID())
+      $this->getApplicationURI('view/'.$document->getID()));
-        ->setHref($this->getApplicationURI('view/'.$document->getID())));
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)

src/applications/macro/controller/PhabricatorMacroAudioController.php

@@ -132,15 +132,8 @@ final class PhabricatorMacroAudioController
     $title = pht('Edit Audio Behavior');
     $crumb = pht('Edit Audio');
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri);
-      id(new PhabricatorCrumbView())
+    $crumbs->addTextCrumb($crumb, $request->getRequestURI());
-        ->setHref($view_uri)
-        ->setName(pht('Macro "%s"', $macro->getName())));
-
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setHref($request->getRequestURI())
-        ->setName($crumb));
 
     $upload_form = id(new AphrontFormView())
       ->setEncType('multipart/form-data')

src/applications/macro/controller/PhabricatorMacroEditController.php

@@ -219,19 +219,13 @@ final class PhabricatorMacroEditController
       $title = pht('Edit Image Macro');
       $crumb = pht('Edit Macro');
 
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri);
-        id(new PhabricatorCrumbView())
-          ->setHref($view_uri)
-          ->setName(pht('Macro "%s"', $macro->getName())));
     } else {
       $title = pht('Create Image Macro');
       $crumb = pht('Create Macro');
     }
 
-    $crumbs->addCrumb(
+    $crumbs->addCrumb($crumb, $request->getRequestURI());
-      id(new PhabricatorCrumbView())
-        ->setHref($request->getRequestURI())
-        ->setName($crumb));
 
     $upload = null;
     if ($macro->getID()) {

src/applications/macro/controller/PhabricatorMacroViewController.php

@@ -30,10 +30,9 @@ final class PhabricatorMacroViewController
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(
-      id(new PhabricatorCrumbView())
+      $title_short,
-        ->setHref($this->getApplicationURI('/view/'.$macro->getID().'/'))
+      $this->getApplicationURI('/view/'.$macro->getID().'/'));
-        ->setName($title_short));
 
     $properties = $this->buildPropertyView($macro, $actions);
     if ($file) {

src/applications/mailinglists/controller/PhabricatorMailingListsEditController.php

@@ -117,13 +117,9 @@ final class PhabricatorMailingListsEditController
           ->addCancelButton($this->getApplicationURI()));
 
     if ($list->getID()) {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Edit Mailing List'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Edit Mailing List')));
     } else {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Create Mailing List'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Create Mailing List')));
     }
 
     $form_box = id(new PHUIObjectBoxView())

src/applications/maniphest/controller/ManiphestBatchEditController.php

@@ -144,9 +144,7 @@ final class ManiphestBatchEditController extends ManiphestController {
     $title = pht('Batch Editor');
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title);
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Batch Edit Tasks'))

src/applications/maniphest/controller/ManiphestReportController.php

@@ -55,9 +55,7 @@ final class ManiphestReportController extends ManiphestController {
     $nav->appendChild($core);
     $nav->setCrumbs(
       $this->buildApplicationCrumbs()
-        ->addCrumb(
+        ->addTextCrumb(pht('Reports')));
-          id(new PhabricatorCrumbView())
-            ->setName(pht('Reports'))));
 
     return $this->buildApplicationPage(
       $nav,

src/applications/maniphest/controller/ManiphestTaskDetailController.php

@@ -367,11 +367,8 @@ final class ManiphestTaskDetailController extends ManiphestController {
     $object_name = 'T'.$task->getID();
     $actions = $this->buildActionView($task);
 
-    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs = $this->buildApplicationCrumbs()
-    $crumbs->addCrumb(
+      ->addTextCrumb($object_name, '/'.$object_name)
-      id(new PhabricatorCrumbView())
-        ->setName($object_name)
-        ->setHref('/'.$object_name))
       ->setActionList($actions);
 
     $header = $this->buildHeaderView($task);

src/applications/maniphest/controller/ManiphestTaskEditController.php

@@ -667,15 +667,10 @@ final class ManiphestTaskEditController extends ManiphestController {
     $crumbs = $this->buildApplicationCrumbs();
 
     if ($task->getID()) {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb('T'.$task->getID(), '/T'.$task->getID());
-        id(new PhabricatorCrumbView())
-          ->setName('T'.$task->getID())
-          ->setHref('/T'.$task->getID()));
     }
 
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($header_name);
-      id(new PhabricatorCrumbView())
-        ->setName($header_name));
 
     return $this->buildApplicationPage(
       array(

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

@@ -24,9 +24,7 @@ final class PhabricatorApplicationDetailViewController
     $title = $selected->getName();
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($selected->getName());
-      id(new PhabricatorCrumbView())
-        ->setName($selected->getName()));
 
     $header = id(new PHUIHeaderView())
       ->setHeader($title)

src/applications/meta/controller/PhabricatorApplicationEditController.php

@@ -146,13 +146,8 @@ final class PhabricatorApplicationEditController
         ->addCancelButton($view_uri));
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($application->getName(), $view_uri);
-      id(new PhabricatorCrumbView())
+    $crumbs->addTextCrumb(pht('Edit Policies'));
-        ->setName($application->getName())
-        ->setHref($view_uri));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Edit Policies')));
 
     $header = id(new PHUIHeaderView())
       ->setHeader(pht('Edit Policies: %s', $application->getName()));

src/applications/nuance/controller/NuanceSourceViewController.php

@@ -47,9 +47,7 @@ final class NuanceSourceViewController extends NuanceController {
 
     $title = pht('%s', $source->getName());
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title);
-      id(new PhabricatorCrumbView())
-      ->setName($title));
 
     $header = $this->buildHeaderView($source);
     $actions = $this->buildActionView($source);

src/applications/owners/controller/PhabricatorOwnersController.php

@@ -45,9 +45,7 @@ abstract class PhabricatorOwnersController extends PhabricatorController {
     }
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title);
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
     $crumbs->addAction(
       id(new PHUIListItemView())

src/applications/passphrase/controller/PassphraseCredentialCreateController.php

@@ -55,9 +55,7 @@ final class PassphraseCredentialCreateController extends PassphraseController {
     $title = pht('New Credential');
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Create'));
-      id(new PhabricatorCrumbView())
-        ->setName(pht('Create')));
 
     $box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Create New Credential'))

src/applications/passphrase/controller/PassphraseCredentialEditController.php

@@ -219,19 +219,14 @@ final class PassphraseCredentialEditController extends PassphraseController {
     if ($is_new) {
       $title = pht('Create Credential');
       $header = pht('Create New Credential');
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Create'));
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Create')));
     } else {
       $title = pht('Edit Credential');
       $header = pht('Edit Credential %s', 'K'.$credential->getID());
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(
-        id(new PhabricatorCrumbView())
+        'K'.$credential->getID(),
-          ->setName('K'.$credential->getID())
+        '/K'.$credential->getID());
-          ->setHref('/K'.$credential->getID()));
+      $crumbs->addTextCrumb(pht('Edit'));
-      $crumbs->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Edit')));
     }
 
     if ($request->isAjax()) {

src/applications/passphrase/controller/PassphraseCredentialViewController.php

@@ -41,9 +41,7 @@ final class PassphraseCredentialViewController extends PassphraseController {
 
     $title = pht('%s %s', 'K'.$credential->getID(), $credential->getName());
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb('K'.$credential->getID());
-      id(new PhabricatorCrumbView())
-        ->setName('K'.$credential->getID()));
 
     $header = $this->buildHeaderView($credential);
     $actions = $this->buildActionView($credential);

src/applications/paste/controller/PhabricatorPasteEditController.php

@@ -212,13 +212,9 @@ final class PhabricatorPasteEditController extends PhabricatorPasteController {
 
     $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
     if (!$is_create) {
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
-        id(new PhabricatorCrumbView())
-          ->setName('P'.$paste->getID())
-          ->setHref('/P'.$paste->getID()));
     }
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($short);
-      id(new PhabricatorCrumbView())->setName($short));
 
     return $this->buildApplicationPage(
       array(

src/applications/paste/controller/PhabricatorPasteViewController.php

@@ -88,10 +88,7 @@ final class PhabricatorPasteViewController extends PhabricatorPasteController {
 
     $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
       ->setActionList($actions)
-      ->addCrumb(
+      ->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
-        id(new PhabricatorCrumbView())
-          ->setName('P'.$paste->getID())
-          ->setHref('/P'.$paste->getID()));
 
     $xactions = id(new PhabricatorPasteTransactionQuery())
       ->setViewer($request->getUser())

src/applications/people/controller/PhabricatorPeopleEditController.php

@@ -23,21 +23,12 @@ final class PhabricatorPeopleEditController
         return new Aphront404Response();
       }
       $base_uri = '/people/edit/'.$user->getID().'/';
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Edit User'), '/people/edit/');
-        id(new PhabricatorCrumbView())
+      $crumbs->addTextCrumb($user->getFullName(), $base_uri);
-          ->setName(pht('Edit User'))
-          ->setHref('/people/edit/'));
-      $crumbs->addCrumb(
-        id(new PhabricatorCrumbView())
-          ->setName($user->getFullName())
-          ->setHref($base_uri));
     } else {
       $user = new PhabricatorUser();
       $base_uri = '/people/edit/';
-      $crumbs->addCrumb(
+      $crumbs->addTextCrumb(pht('Create New User'), $base_uri);
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Create New User'))
-          ->setHref($base_uri));
     }
 
     $nav = new AphrontSideNavFilterView();

src/applications/people/controller/PhabricatorPeopleLdapController.php

@@ -38,10 +38,9 @@ final class PhabricatorPeopleLdapController
       ->appendChild($form);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(
-      id(new PhabricatorCrumbView())
+      pht('Import Ldap Users'),
-        ->setName(pht('Import Ldap Users'))
+      $this->getApplicationURI('/ldap/'));
-        ->setHref($this->getApplicationURI('/ldap/')));
 
     $nav = $this->buildSideNavView();
     $nav->setCrumbs($crumbs);

src/applications/people/controller/PhabricatorPeopleLogsController.php

@@ -207,10 +207,7 @@ final class PhabricatorPeopleLogsController
     $filter = new AphrontListFilterView();
     $filter->appendChild($form);
     $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb(pht('Activity Logs'), '/people/logs/');
-        id(new PhabricatorCrumbView())
-          ->setName(pht('Activity Logs'))
-          ->setHref('/people/logs/'));
 
     $nav = $this->buildSideNavView();
     $nav->selectFilter('logs');

src/applications/people/controller/PhabricatorPeopleProfileController.php

@@ -71,9 +71,7 @@ final class PhabricatorPeopleProfileController
     $properties = $this->buildPropertyView($user, $actions);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($user->getUsername());
-      id(new PhabricatorCrumbView())
-        ->setName($user->getUsername()));
     $feed = $this->renderUserFeed($user);
 
     $object_box = id(new PHUIObjectBoxView())

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

@@ -61,13 +61,8 @@ final class PhabricatorPeopleProfileEditController
 
     $title = pht('Edit Profile');
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($user->getUsername(), $profile_uri);
-      id(new PhabricatorCrumbView())
+    $crumbs->addTextCrumb($title);
-        ->setName($user->getUsername())
-        ->setHref($profile_uri));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
     $form = id(new AphrontFormView())
       ->setUser($viewer);

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

@@ -91,13 +91,8 @@ final class PhabricatorPeopleProfilePictureController
 
     $title = pht('Edit Profile Picture');
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($user->getUsername(), $profile_uri);
-      id(new PhabricatorCrumbView())
+    $crumbs->addTextCrumb($title);
-        ->setName($user->getUsername())
-        ->setHref($profile_uri));
-    $crumbs->addCrumb(
-      id(new PhabricatorCrumbView())
-        ->setName($title));
 
     $form = id(new PHUIFormLayoutView())
       ->setUser($viewer);

src/applications/phame/controller/blog/PhameBlogEditController.php

@@ -176,10 +176,7 @@ final class PhameBlogEditController
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($page_title, $this->getApplicationURI('blog/new'));
-      id(new PhabricatorCrumbView())
-        ->setName($page_title)
-        ->setHref($this->getApplicationURI('blog/new')));
 
     $nav = $this->renderSideNavFilterView();
     $nav->selectFilter($this->id ? null : 'blog/new');

src/applications/phame/controller/blog/PhameBlogListController.php

@@ -48,10 +48,7 @@ final class PhameBlogListController extends PhameController {
     $blog_list->setPager($pager);
 
     $crumbs = $this->buildApplicationCrumbs();
-    $crumbs->addCrumb(
+    $crumbs->addTextCrumb($title, $this->getApplicationURI());
-      id(new PhabricatorCrumbView())
-        ->setName($title)
-        ->setHref($this->getApplicationURI()));
 
     $nav->appendChild(
       array(