From a5e8bbf3f43094173e1ceaa0ad72fb3da34df3b2 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Sun, 28 Jun 2015 18:02:44 -0700
Subject: [PATCH] [Redesign] Home nav normalization

Summary: Ref T8099, makes the home nav elements more resilient to font size changes, fixes alignment on mobile.

Test Plan: Review home nav with smaller and larger font, check hover states, check phone layouts.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13465
---
 resources/celerity/map.php                         | 10 +++++-----
 webroot/rsrc/css/aphront/phabricator-nav-view.css  |  1 +
 .../base/phabricator-application-launch-view.css   | 14 ++++++++++----
 3 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index d7bab446cb..7a5069a185 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '2456ec12',
+    'core.pkg.css' => 'b8d31fec',
     'core.pkg.js' => 'a590b451',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => '1b36e899',
@@ -24,7 +24,7 @@ return array(
     'rsrc/css/aphront/multi-column.css' => 'fd18389d',
     'rsrc/css/aphront/notification.css' => '9c279160',
     'rsrc/css/aphront/panel-view.css' => '8427b78d',
-    'rsrc/css/aphront/phabricator-nav-view.css' => 'f1982787',
+    'rsrc/css/aphront/phabricator-nav-view.css' => 'a24cb589',
     'rsrc/css/aphront/table-view.css' => 'e3632cc9',
     'rsrc/css/aphront/tokenizer.css' => '04875312',
     'rsrc/css/aphront/tooltip.css' => '7672b60f',
@@ -35,7 +35,7 @@ return array(
     'rsrc/css/application/auth/auth.css' => 'dc62cb0e',
     'rsrc/css/application/base/main-menu-view.css' => '09265034',
     'rsrc/css/application/base/notification-menu.css' => 'f31c0bde',
-    'rsrc/css/application/base/phabricator-application-launch-view.css' => 'fa820ddf',
+    'rsrc/css/application/base/phabricator-application-launch-view.css' => '077e63cb',
     'rsrc/css/application/base/phui-theme.css' => 'f54d2901',
     'rsrc/css/application/base/standard-page-view.css' => 'def344d6',
     'rsrc/css/application/calendar/calendar-icon.css' => 'c69aa59f',
@@ -706,7 +706,7 @@ return array(
     'path-typeahead' => 'f7fc67ec',
     'people-profile-css' => '25970776',
     'phabricator-action-list-view-css' => '32c388b3',
-    'phabricator-application-launch-view-css' => 'fa820ddf',
+    'phabricator-application-launch-view-css' => '077e63cb',
     'phabricator-busy' => '59a7976a',
     'phabricator-chatlog-css' => 'd295b020',
     'phabricator-content-source-view-css' => '4b8b05d4',
@@ -725,7 +725,7 @@ return array(
     'phabricator-keyboard-shortcut' => '1ae869f2',
     'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
     'phabricator-main-menu-view' => '09265034',
-    'phabricator-nav-view-css' => 'f1982787',
+    'phabricator-nav-view-css' => 'a24cb589',
     'phabricator-notification' => 'ccf1cbf8',
     'phabricator-notification-css' => '9c279160',
     'phabricator-notification-menu-css' => 'f31c0bde',
diff --git a/webroot/rsrc/css/aphront/phabricator-nav-view.css b/webroot/rsrc/css/aphront/phabricator-nav-view.css
index 62d5dfc5cf..52a977c13e 100644
--- a/webroot/rsrc/css/aphront/phabricator-nav-view.css
+++ b/webroot/rsrc/css/aphront/phabricator-nav-view.css
@@ -79,4 +79,5 @@
 .device-phone .phabricator-side-menu-home .phabricator-nav-local {
   width: 100%;
   padding-top: 0;
+  margin-top: 0;
 }
diff --git a/webroot/rsrc/css/application/base/phabricator-application-launch-view.css b/webroot/rsrc/css/application/base/phabricator-application-launch-view.css
index 2fa2753b58..1186828646 100644
--- a/webroot/rsrc/css/application/base/phabricator-application-launch-view.css
+++ b/webroot/rsrc/css/application/base/phabricator-application-launch-view.css
@@ -29,9 +29,9 @@ div.phabricator-application-launch-container {
   position: relative;
   text-decoration: none;
   width: 100%;
-  height: 44px;
   border-top-right-radius: 3px;
   border-bottom-right-radius: 3px;
+  padding: 4px 0;
 }
 
 .device-phone div.phabricator-application-launch-container {
@@ -42,7 +42,7 @@ div.phabricator-application-launch-container {
   position: absolute;
   width: 18px;
   height: 18px;
-  top: 8px;
+  top: 12px;
   left: 10px;
   font-size: 18px;
   text-align: center;
@@ -56,23 +56,29 @@ div.phabricator-application-launch-container {
   text-decoration: none;
 }
 
+.device-desktop a.phabricator-application-launch-container:hover
+  .phabricator-application-launch-icon {
+  color: {$sky};
+}
+
 .phabricator-application-launch-name {
   display: block;
   font-weight: bold;
   color: {$darkbluetext};
   font-size: {$normalfontsize};
-  margin: 6px 0 2px 38px;
+  margin-left: 36px;
 }
 
 .phabricator-application-launch-description {
   color: {$bluetext};
   font-size: {$smallestfontsize};
-  margin-left: 38px;
+  margin-left: 36px;
   text-overflow: ellipsis;
   width: 150px;
   overflow: hidden;
   white-space: nowrap;
   display: inline-block;
+  padding: 2px 0 0 0;
 }
 
 .phabricator-application-launch-attention {