Use ApplicationTransactions when indexing commit/audit comments

Summary:
Ref T4896. Depends on D10056. Moves search indexing to standard infrastructure.

Also, fixes a bug where inline comments would not be indexed.

Test Plan: Used `bin/search index ... --trace` to view index construction of a commit, saw all the comments and inlines get indexed.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T4896

Differential Revision: https://secure.phabricator.com/D10057

src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php

@@ -66,27 +66,10 @@ final class PhabricatorRepositoryCommitSearchIndexer
       PhabricatorRepositoryRepositoryPHIDType::TYPECONST,
       $date_created);
 
-    $comments = PhabricatorAuditComment::loadComments(
+    $this->indexTransactions(
-      $this->getViewer(),
+      $doc,
-      $commit->getPHID());
+      new PhabricatorAuditTransactionQuery(),
-    foreach ($comments as $comment) {
+      array($commit->getPHID()));
-      if (strlen($comment->getContent())) {
-        $doc->addField(
-          PhabricatorSearchField::FIELD_COMMENT,
-          $comment->getContent());
-      }
-    }
-
-    $inlines = PhabricatorAuditInlineComment::loadPublishedComments(
-      $this->getViewer(),
-      $commit->getPHID());
-    foreach ($inlines as $inline) {
-      if (strlen($inline->getContent())) {
-        $doc->addField(
-          PhabricatorSearchField::FIELD_COMMENT,
-          $inline->getContent());
-      }
-    }
 
     return $doc;
   }

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

@@ -101,7 +101,6 @@ abstract class PhabricatorSearchDocumentIndexer {
     $xactions = id(clone $query)
       ->setViewer($this->getViewer())
       ->withObjectPHIDs($phids)
-      ->withTransactionTypes(array(PhabricatorTransactions::TYPE_COMMENT))
       ->execute();
 
     foreach ($xactions as $xaction) {