revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 01:10:58 +01:00
Code Issues Releases Wiki Activity

Fix spurious timeline entry for badges

Browse source 
Summary: Fixes T11164. At least, this fixes it locally for me. I don't know how to code. Copy Pasta!

Test Plan: Change name, don't see extra timeline entry on quality set anymore.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T11164

Differential Revision: https://secure.phabricator.com/D16169
This commit is contained in:
Chad Little 2016-06-22 13:23:11 -07:00
parent 3bb3170a2c
commit a75eea7637
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/badges/editor/PhabricatorBadgesEditor.php
View file

@ -47,7 +47,7 @@ final class PhabricatorBadgesEditor
case PhabricatorBadgesTransaction::TYPE_ICON: case PhabricatorBadgesTransaction::TYPE_ICON:
return $object->getIcon(); return $object->getIcon();
case PhabricatorBadgesTransaction::TYPE_QUALITY: case PhabricatorBadgesTransaction::TYPE_QUALITY:
return $object->getQuality(); return (int)$object->getQuality();
case PhabricatorBadgesTransaction::TYPE_STATUS: case PhabricatorBadgesTransaction::TYPE_STATUS:
return $object->getStatus(); return $object->getStatus();
case PhabricatorBadgesTransaction::TYPE_AWARD: case PhabricatorBadgesTransaction::TYPE_AWARD:

6
src/applications/badges/storage/PhabricatorBadgesTransaction.php
View file

@ -105,14 +105,14 @@ final class PhabricatorBadgesTransaction
} }
break; break;
case self::TYPE_QUALITY: case self::TYPE_QUALITY:
$qual_new = PhabricatorBadgesQuality::getQualityName($new);
$qual_old = PhabricatorBadgesQuality::getQualityName($old);
if ($old === null) { if ($old === null) {
return pht( return pht(
'%s set the quality for this badge as "%s".', '%s set the quality for this badge as "%s".',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
$new); $qual_new);
} else { } else {
$qual_new = PhabricatorBadgesQuality::getQualityName($new);
$qual_old = PhabricatorBadgesQuality::getQualityName($old);
return pht( return pht(
'%s updated the quality for this badge from "%s" to "%s".', '%s updated the quality for this badge from "%s" to "%s".',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),