revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 15:21:03 +01:00
Code Issues Releases Wiki Activity

Fix not blocking / not blocked queries

Browse source 
Summary: Fixes T7434. We need to LEFT JOIN, not JOIN here, because we still want result rows where the value is `null`.

Test Plan: Issued blocked/not-blocked + blocking/not-blocking queries, got results in all cases.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7434

Differential Revision: https://secure.phabricator.com/D11939
This commit is contained in:
epriestley 2015-03-02 17:00:20 -08:00
parent e651169879
commit a76049abd4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/maniphest/query/ManiphestTaskQuery.php
View file

@ -792,7 +792,7 @@ final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery {
$conn_r,
'LEFT JOIN %T blocking ON blocking.src = task.phid '.
'AND blocking.type = %d '.
'JOIN %T blockingtask ON blocking.dst = blockingtask.phid '.
'LEFT JOIN %T blockingtask ON blocking.dst = blockingtask.phid '.
'AND blockingtask.status IN (%Ls)',
$edge_table,
ManiphestTaskDependedOnByTaskEdgeType::EDGECONST,
@ -804,7 +804,7 @@ final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery {
$conn_r,
'LEFT JOIN %T blocked ON blocked.src = task.phid '.
'AND blocked.type = %d '.
'JOIN %T blockedtask ON blocked.dst = blockedtask.phid '.
'LEFT JOIN %T blockedtask ON blocked.dst = blockedtask.phid '.
'AND blockedtask.status IN (%Ls)',
$edge_table,
ManiphestTaskDependsOnTaskEdgeType::EDGECONST,