From a76e91ea9ef6d17987c819b595fd5c7a638c70a5 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 29 Apr 2019 11:23:33 -0700
Subject: [PATCH] Remove obsolete Dashboard panel methods with no callsites

Summary: Ref T13272. Since the move to EditEngine, these methods have no callsites.

Test Plan: `grep`

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13272

Differential Revision: https://secure.phabricator.com/D20484
---
 .../PhabricatorDashboardPanelType.php         |  7 -----
 .../PhabricatorDashboardQueryPanelType.php    | 27 -------------------
 2 files changed, 34 deletions(-)

diff --git a/src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php b/src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php
index d6311e7765..ecb1658f44 100644
--- a/src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php
+++ b/src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php
@@ -12,13 +12,6 @@ abstract class PhabricatorDashboardPanelType extends Phobject {
     PhabricatorDashboardPanel $panel,
     PhabricatorDashboardPanelRenderingEngine $engine);
 
-  public function initializeFieldsFromRequest(
-    PhabricatorDashboardPanel $panel,
-    PhabricatorCustomFieldList $field_list,
-    AphrontRequest $request) {
-    return;
-  }
-
   /**
    * Should this panel pull content in over AJAX?
    *
diff --git a/src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php b/src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php
index 9e0da25c43..2174f793a4 100644
--- a/src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php
+++ b/src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php
@@ -55,33 +55,6 @@ final class PhabricatorDashboardQueryPanelType
     );
   }
 
-  public function initializeFieldsFromRequest(
-    PhabricatorDashboardPanel $panel,
-    PhabricatorCustomFieldList $field_list,
-    AphrontRequest $request) {
-
-    $map = array();
-    if (strlen($request->getStr('engine'))) {
-      $map['class'] = $request->getStr('engine');
-    }
-
-    if (strlen($request->getStr('query'))) {
-      $map['key'] = $request->getStr('query');
-    }
-
-    $full_map = array();
-    foreach ($map as $key => $value) {
-      $full_map["std:dashboard:core:{$key}"] = $value;
-    }
-
-    foreach ($field_list->getFields() as $field) {
-      $field_key = $field->getFieldKey();
-      if (isset($full_map[$field_key])) {
-        $field->setValueFromStorage($full_map[$field_key]);
-      }
-    }
-  }
-
   public function renderPanelContent(
     PhabricatorUser $viewer,
     PhabricatorDashboardPanel $panel,