Remove all reads of ReleephProject->repositoryID

Summary:
Ref T3655. ReleephProject currently has both `repositoryID` and `repositoryPHID`, which point to the same object and are reudundant. Get rid of all reads of `repositoryID`.

NOTE: This makes project loads depend on repository loads. The eventual rule here will be that you must be able to see a repository in order to see projects for that repository, which seems like a reasonable rule. We might need to tailor it more than this (e.g., if there are branch read permissions down the line) but this seems like a reasonable minimum.

Test Plan: Grepped for `repositoryID` in `releeph/`. Called `releeph.getbranches`.

Reviewers: btrahan

Reviewed By: btrahan

CC: LegNeato, aran

Maniphest Tasks: T3655

Differential Revision: https://secure.phabricator.com/D6633

src/applications/releeph/conduit/ConduitAPI_releeph_getbranches_Method.php

@@ -24,13 +24,13 @@ final class ConduitAPI_releeph_getbranches_Method
   protected function execute(ConduitAPIRequest $request) {
     $results = array();
 
-    $projects = id(new ReleephProject())->loadAllWhere('isActive = 1');
+    $projects = id(new ReleephProjectQuery())
+      ->setViewer($request->getUser())
+      ->withActive(1)
+      ->execute();
 
     foreach ($projects as $project) {
-      $repository = $project->loadOneRelative(
+      $repository = $project->getRepository();
-        id(new PhabricatorRepository()),
-        'id',
-        'getRepositoryID');
 
       $branches = $project->loadRelatives(
         id(new ReleephBranch()),

src/applications/releeph/controller/project/ReleephProjectListController.php

@@ -69,18 +69,14 @@ final class ReleephProjectListController extends ReleephController
             ->setHref($enable_uri));
       }
 
-      // TODO: See T3551.
+      $repo = $project->getRepository();
-
+      $item->addAttribute(
-      $repo = $project->loadPhabricatorRepository();
+        phutil_tag(
-      if ($repo) {
+          'a',
-        $item->addAttribute(
+          array(
-          phutil_tag(
+            'href' => '/diffusion/'.$repo->getCallsign().'/',
-            'a',
+          ),
-            array(
+          'r'.$repo->getCallsign()));
-              'href' => '/diffusion/'.$repo->getCallsign().'/',
-            ),
-            'r'.$repo->getCallsign()));
-      }
 
       $arc = $project->loadArcanistProject();
       if ($arc) {

src/applications/releeph/query/ReleephProjectQuery.php

@@ -7,6 +7,8 @@ final class ReleephProjectQuery
   private $ids;
   private $phids;
 
+  private $needRepositories;
+
   private $order    = 'order-id';
   const ORDER_ID    = 'order-id';
   const ORDER_NAME  = 'order-name';
@@ -46,6 +48,29 @@ final class ReleephProjectQuery
     return $table->loadAllFromArray($rows);
   }
 
+  public function willFilterPage(array $projects) {
+    assert_instances_of($projects, 'ReleephProject');
+
+    $repository_phids = mpull($projects, 'getRepositoryPHID');
+
+    $repositories = id(new PhabricatorRepositoryQuery())
+      ->setViewer($this->getViewer())
+      ->withPHIDs($repository_phids)
+      ->execute();
+    $repositories = mpull($repositories, null, 'getPHID');
+
+    foreach ($projects as $key => $project) {
+      $repo = idx($repositories, $project->getRepositoryPHID());
+      if (!$repo) {
+        unset($projects[$key]);
+        continue;
+      }
+      $project->attachRepository($repo);
+    }
+
+    return $projects;
+  }
+
   private function buildWhereClause(AphrontDatabaseConnection $conn_r) {
     $where = array();
 
@@ -53,7 +78,7 @@ final class ReleephProjectQuery
       $where[] = qsprintf(
         $conn_r,
         'isActive = %d',
-        $this->active);
+        (int)$this->active);
     }
 
     if ($this->ids) {

src/applications/releeph/storage/ReleephProject.php

@@ -27,6 +27,8 @@ final class ReleephProject extends ReleephDAO
 
   protected $details = array();
 
+  private $repository = self::ATTACHABLE;
+
   public function getConfiguration() {
     return array(
       self::CONFIG_AUX_PHID => true,
@@ -111,11 +113,21 @@ final class ReleephProject extends ReleephDAO
     }
   }
 
+  public function attachRepository(PhabricatorRepository $repository) {
+    $this->repository = $repository;
+    return $this;
+  }
+
+  public function getRepository() {
+    return $this->assertAttached($this->repository);
+  }
+
+  // TODO: Remove once everything uses ProjectQuery.
   public function loadPhabricatorRepository() {
     return $this->loadOneRelative(
       new PhabricatorRepository(),
-      'id',
+      'phid',
-      'getRepositoryID');
+      'getRepositoryPHID');
   }
 
   public function getCurrentReleaseNumber() {