Remove extra side navs in Herald

Summary: Ref T2769. Removes some nonstandard side navs.

Test Plan: Viewed affected pages.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2769

Differential Revision: https://secure.phabricator.com/D6651

src/applications/herald/controller/HeraldNewController.php

@@ -60,7 +60,7 @@ final class HeraldNewController extends HeraldController {
       ->setFlexible(true)
       ->appendChild(
         id(new AphrontFormSelectControl())
-          ->setLabel(pht('New rule for'))
+          ->setLabel(pht('New Rule for'))
           ->setName('content_type')
           ->setValue($this->contentType)
           ->setOptions($content_type_map))
@@ -78,13 +78,11 @@ final class HeraldNewController extends HeraldController {
           ->setHref($this->getApplicationURI(
             'view/'.$this->contentType.'/'.$this->ruleType)));
 
-    $nav = $this->renderNav();
-    $nav->selectFilter('new');
-    $nav->appendChild($form);
-    $nav->setCrumbs($crumbs);
-
     return $this->buildApplicationPage(
-      $nav,
+      array(
+        $crumbs,
+        $form,
+      ),
       array(
         'title' => pht('Create Herald Rule'),
         'device' => true,

src/applications/herald/controller/HeraldRuleController.php

@@ -179,21 +179,14 @@ final class HeraldRuleController extends HeraldController {
       ->buildApplicationCrumbs()
       ->addCrumb(
         id(new PhabricatorCrumbView())
-          ->setName($title)
-          ->setHref('#'));
-
-    $nav = $this->renderNav();
-    $nav->setCrumbs($crumbs);
-    $nav->selectFilter(
-      'view/'.$rule->getContentType().'/'.$rule->getRuleType());
-    $nav->appendChild(
-      array(
-        $error_view,
-        $form,
-      ));
+          ->setName($title));
 
     return $this->buildApplicationPage(
-      $nav,
+      array(
+        $crumbs,
+        $error_view,
+        $form,
+      ),
       array(
         'title' => pht('Edit Rule'),
         'dust' => true,