From a808133bc8649fe50f5721b023ad6d91affd5777 Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Fri, 1 Feb 2013 17:22:48 -0800
Subject: [PATCH] Not require confirmation for revision subscribe and
 unsubscribe

Summary: Regression to original behavior.

Test Plan: Clicked on it twice, didn't see confirmation dialog.

Reviewers: epriestley, codeblock

Reviewed By: codeblock

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4788
---
 .../controller/DifferentialRevisionViewController.php            | 1 -
 .../differential/view/DifferentialRevisionDetailView.php         | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
index 5593053e22..2ede65d59b 100644
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -498,7 +498,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
           'href'    => "/differential/subscribe/{$action}/{$revision_id}/",
           'name'    => $viewer_is_cc ? pht('Unsubscribe') : pht('Subscribe'),
           'instant' => true,
-          'sigil' => 'workflow',
         );
       } else {
         $links[] = array(
diff --git a/src/applications/differential/view/DifferentialRevisionDetailView.php b/src/applications/differential/view/DifferentialRevisionDetailView.php
index 8e366f560c..6b0a9fa3e4 100644
--- a/src/applications/differential/view/DifferentialRevisionDetailView.php
+++ b/src/applications/differential/view/DifferentialRevisionDetailView.php
@@ -52,6 +52,7 @@ final class DifferentialRevisionDetailView extends AphrontView {
         ->setName($action['name'])
         ->setHref(idx($action, 'href'))
         ->setWorkflow(idx($action, 'sigil') == 'workflow')
+        ->setRenderAsForm(!empty($action['instant']))
         ->setUser($user)
         ->setDisabled(idx($action, 'disabled', false));
       $actions->addAction($obj);