From a84cc1ab731a8e7e3888860319219ee7b8127724 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 21 Feb 2014 12:56:38 -0800
Subject: [PATCH] Fix (?) an issue with CCs not being written into commit
 messages properly

Summary: Report from @zeeg, I think this is the root issue. Currently, if a project is CC'd we'll write "CC: projectname", but should write "CC: #projectname".

Test Plan: Verified that we now write "CC: #projectname".

Reviewers: btrahan, zeeg

Reviewed By: zeeg

CC: zeeg, aran

Differential Revision: https://secure.phabricator.com/D8296
---
 .../field/specification/DifferentialCCsFieldSpecification.php   | 2 +-
 .../specification/DifferentialReviewersFieldSpecification.php   | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php b/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
index 01e83e4846..92c3106345 100644
--- a/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
+++ b/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
@@ -90,7 +90,7 @@ final class DifferentialCCsFieldSpecification
     foreach ($this->ccs as $phid) {
       $handle = $this->getHandle($phid);
       if ($handle->isComplete()) {
-        $names[] = $handle->getName();
+        $names[] = $handle->getObjectName();
       }
     }
     return implode(', ', $names);
diff --git a/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php b/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
index b82267c7c2..35c47afef7 100644
--- a/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
+++ b/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
@@ -130,8 +130,6 @@ final class DifferentialReviewersFieldSpecification
       return null;
     }
 
-    $project_type = PhabricatorProjectPHIDTypeProject::TYPECONST;
-
     $names = array();
     foreach ($this->reviewers as $phid) {
       $names[] = $this->getHandle($phid)->getObjectName();