From a858c1479175f9692b636d79b51847958ccd68ca Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 9 Mar 2013 17:55:14 -0800 Subject: [PATCH] Implicitly CC inline commenters in Pholio Summary: Fixes T2722. Both the "comment" (default) and "inline comment" (needs to be specialized) actions should imply CC. Test Plan: Made an inline on a mock, got implicitly cc'd. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2722 Differential Revision: https://secure.phabricator.com/D5312 --- src/applications/pholio/editor/PholioMockEditor.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/applications/pholio/editor/PholioMockEditor.php b/src/applications/pholio/editor/PholioMockEditor.php index 71a82a05bb..eadfda86bf 100644 --- a/src/applications/pholio/editor/PholioMockEditor.php +++ b/src/applications/pholio/editor/PholioMockEditor.php @@ -158,4 +158,16 @@ final class PholioMockEditor extends PhabricatorApplicationTransactionEditor { } + protected function shouldImplyCC( + PhabricatorLiskDAO $object, + PhabricatorApplicationTransaction $xaction) { + + switch ($xaction->getTransactionType()) { + case PholioTransactionType::TYPE_INLINE: + return true; + } + + return parent::shouldImplyCC($object, $xaction); + } + }