From a894c9993512fcb24cd4389ad150dfea71f73cff Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 1 Jun 2018 13:12:13 -0700 Subject: [PATCH] Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI Summary: Fixes T13148. Ref T13105. The new document rendering engine for images let them overflow the UI bounds. Add `max-width: 100%;` to keep them contained. Test Plan: - Viewed a very wide image in Safari, Firefox and Chrome. Saw sensible rendering. - Also viewed a normal image, saw normal behavior. Reviewers: amckinley, avivey Reviewed By: avivey Maniphest Tasks: T13148, T13105 Differential Revision: https://secure.phabricator.com/D19457 --- resources/celerity/map.php | 6 +++--- webroot/rsrc/css/phui/phui-property-list-view.css | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index dbd9b9c33b..bef8bd053a 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => 'e68cf1fa', 'conpherence.pkg.js' => '15191c65', - 'core.pkg.css' => '8be474cc', + 'core.pkg.css' => '8e3d1fb7', 'core.pkg.js' => '2058ec09', 'differential.pkg.css' => '06dc617c', 'differential.pkg.js' => 'c2ca903a', @@ -167,7 +167,7 @@ return array( 'rsrc/css/phui/phui-object-box.css' => '9cff003c', 'rsrc/css/phui/phui-pager.css' => 'edcbc226', 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e', - 'rsrc/css/phui/phui-property-list-view.css' => 'de4754d8', + 'rsrc/css/phui/phui-property-list-view.css' => '546a04ae', 'rsrc/css/phui/phui-remarkup-preview.css' => '54a34863', 'rsrc/css/phui/phui-segment-bar-view.css' => 'b1d1b892', 'rsrc/css/phui/phui-spacing.css' => '042804d6', @@ -842,7 +842,7 @@ return array( 'phui-oi-simple-ui-css' => 'a8beebea', 'phui-pager-css' => 'edcbc226', 'phui-pinboard-view-css' => '2495140e', - 'phui-property-list-view-css' => 'de4754d8', + 'phui-property-list-view-css' => '546a04ae', 'phui-remarkup-preview-css' => '54a34863', 'phui-segment-bar-view-css' => 'b1d1b892', 'phui-spacing-css' => '042804d6', diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css index 15632c902f..ed7fb95a7b 100644 --- a/webroot/rsrc/css/phui/phui-property-list-view.css +++ b/webroot/rsrc/css/phui/phui-property-list-view.css @@ -207,6 +207,7 @@ div.phui-property-list-stacked .phui-property-list-properties .document-engine-image img { margin: 20px auto; background: url('/rsrc/image/checker_light.png'); + max-width: 100%; } .device-desktop .document-engine-image img:hover {