1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-02 09:58:24 +01:00

Expose Differential actions for "transaction.search" in a basic way

Summary:
See PHI725. Ref T13151. These actions are somewhat unusual and I considered different ways to represent them (make them look like "status" transactions; build multiple synthetic transactions) but ultimately landed on the simplest approach of just exposing them more or less as they exist internally.

I haven't included data for any of them. Most don't really have any data, but "accept" does. I'm holding off on providing more data until after T731, which may shake up the internal format.

Test Plan: Applied most of these transactions against a revision, queried for it with `transaction.search`, got distinguishable transactions out.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19509
This commit is contained in:
epriestley 2018-06-27 09:48:18 -07:00
parent 11f1c13915
commit a94528ee4a
10 changed files with 72 additions and 1 deletions

View file

@ -86,4 +86,12 @@ final class DifferentialRevisionAbandonTransaction
$this->renderObject());
}
public function getTransactionTypeForConduit($xaction) {
return 'abandon';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}

View file

@ -234,4 +234,12 @@ final class DifferentialRevisionAcceptTransaction
$this->renderObject());
}
public function getTransactionTypeForConduit($xaction) {
return 'accept';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}

View file

@ -154,5 +154,4 @@ final class DifferentialRevisionCloseTransaction
);
}
}

View file

@ -87,4 +87,12 @@ final class DifferentialRevisionCommandeerTransaction
$this->renderObject());
}
public function getTransactionTypeForConduit($xaction) {
return 'commandeer';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}

View file

@ -119,4 +119,12 @@ final class DifferentialRevisionPlanChangesTransaction
return (bool)$this->getMetadataValue('draft.demote');
}
public function getTransactionTypeForConduit($xaction) {
return 'plan-changes';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}

View file

@ -85,4 +85,12 @@ final class DifferentialRevisionReclaimTransaction
$this->renderObject());
}
public function getTransactionTypeForConduit($xaction) {
return 'reclaim';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}

View file

@ -99,4 +99,12 @@ final class DifferentialRevisionRejectTransaction
$this->renderObject());
}
public function getTransactionTypeForConduit($xaction) {
return 'request-changes';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}

View file

@ -72,4 +72,12 @@ final class DifferentialRevisionReopenTransaction
$this->renderObject());
}
public function getTransactionTypeForConduit($xaction) {
return 'reopen';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}

View file

@ -84,4 +84,12 @@ final class DifferentialRevisionRequestReviewTransaction
$this->renderObject());
}
public function getTransactionTypeForConduit($xaction) {
return 'request-review';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}

View file

@ -93,4 +93,12 @@ final class DifferentialRevisionResignTransaction
$this->renderObject());
}
public function getTransactionTypeForConduit($xaction) {
return 'resign';
}
public function getFieldValuesForConduit($object, $data) {
return array();
}
}