From a9845b0b1d83129e252142b180ded5b160fb9feb Mon Sep 17 00:00:00 2001 From: Chad Little Date: Wed, 12 Apr 2017 14:10:18 -0700 Subject: [PATCH] Remove picture crop transaction from Conpherence Summary: Fixes T11730. Removes an old transaction that hasn't been used in a year. Test Plan: Run sql, check various rooms. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11730 Differential Revision: https://secure.phabricator.com/D17666 --- .../sql/autopatches/20170412.conpherence.01.picturecrop.sql | 2 ++ .../conpherence/storage/ConpherenceTransaction.php | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) create mode 100644 resources/sql/autopatches/20170412.conpherence.01.picturecrop.sql diff --git a/resources/sql/autopatches/20170412.conpherence.01.picturecrop.sql b/resources/sql/autopatches/20170412.conpherence.01.picturecrop.sql new file mode 100644 index 0000000000..760a19f119 --- /dev/null +++ b/resources/sql/autopatches/20170412.conpherence.01.picturecrop.sql @@ -0,0 +1,2 @@ +DELETE FROM {$NAMESPACE}_conpherence.conpherence_transaction + WHERE transactionType = 'picture-crop'; diff --git a/src/applications/conpherence/storage/ConpherenceTransaction.php b/src/applications/conpherence/storage/ConpherenceTransaction.php index b311c80ca5..3706b4a210 100644 --- a/src/applications/conpherence/storage/ConpherenceTransaction.php +++ b/src/applications/conpherence/storage/ConpherenceTransaction.php @@ -7,7 +7,6 @@ final class ConpherenceTransaction extends PhabricatorApplicationTransaction { const TYPE_PARTICIPANTS = 'participants'; const TYPE_DATE_MARKER = 'date-marker'; const TYPE_PICTURE = 'picture'; - const TYPE_PICTURE_CROP = 'picture-crop'; // TODO: Nuke these from DB. public function getApplicationName() { return 'conpherence'; @@ -43,8 +42,6 @@ final class ConpherenceTransaction extends PhabricatorApplicationTransaction { case self::TYPE_PICTURE: case self::TYPE_DATE_MARKER: return false; - case self::TYPE_PICTURE_CROP: - return true; } return parent::shouldHide();