1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00

Fix Mercurial commit history ordering

Summary:
See <https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825>.

In D18769, I rewrote this from using the `--branch` flag (which is unsafe and does not function on branches named `--config=x.y` and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan: Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18817
This commit is contained in:
epriestley 2017-12-05 05:35:06 -08:00
parent 46d496b8cc
commit a989dd181d

View file

@ -130,7 +130,7 @@ final class DiffusionHistoryQueryConduitAPIMethod
} else {
$path_arg = '';
$revset_arg = hgsprintf(
'branch(%s) and reverse(ancestors(%s))',
'reverse(ancestors(%s)) and branch(%s)',
$drequest->getBranch(),
$commit_hash);
}