From a9d7b4f0ff75f62df2d8df0f1064570699702778 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 19 Jan 2018 14:57:23 -0800
Subject: [PATCH] Support bulk edit of "points" for Maniphest tasks

Summary: Ref T13025. Fixes T10973. Fairly straightforward. The "points" type is just an alias for "text" today.

Test Plan: Bulk edited points.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13025, T10973

Differential Revision: https://secure.phabricator.com/D18889
---
 src/__phutil_library_map__.php                         |  2 ++
 .../maniphest/editor/ManiphestEditEngine.php           |  1 +
 .../transactions/bulk/type/BulkPointsParameterType.php | 10 ++++++++++
 .../editfield/PhabricatorPointsEditField.php           |  5 +++++
 4 files changed, 18 insertions(+)
 create mode 100644 src/applications/transactions/bulk/type/BulkPointsParameterType.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 2b46a40970..0cd6ee0333 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -223,6 +223,7 @@ phutil_register_library_map(array(
     'AuditQueryConduitAPIMethod' => 'applications/audit/conduit/AuditQueryConduitAPIMethod.php',
     'AuthManageProvidersCapability' => 'applications/auth/capability/AuthManageProvidersCapability.php',
     'BulkParameterType' => 'applications/transactions/bulk/type/BulkParameterType.php',
+    'BulkPointsParameterType' => 'applications/transactions/bulk/type/BulkPointsParameterType.php',
     'BulkRemarkupParameterType' => 'applications/transactions/bulk/type/BulkRemarkupParameterType.php',
     'BulkSelectParameterType' => 'applications/transactions/bulk/type/BulkSelectParameterType.php',
     'BulkStringParameterType' => 'applications/transactions/bulk/type/BulkStringParameterType.php',
@@ -5252,6 +5253,7 @@ phutil_register_library_map(array(
     'AuditQueryConduitAPIMethod' => 'AuditConduitAPIMethod',
     'AuthManageProvidersCapability' => 'PhabricatorPolicyCapability',
     'BulkParameterType' => 'Phobject',
+    'BulkPointsParameterType' => 'BulkParameterType',
     'BulkRemarkupParameterType' => 'BulkParameterType',
     'BulkSelectParameterType' => 'BulkParameterType',
     'BulkStringParameterType' => 'BulkParameterType',
diff --git a/src/applications/maniphest/editor/ManiphestEditEngine.php b/src/applications/maniphest/editor/ManiphestEditEngine.php
index 8df261dc4a..359ba493d4 100644
--- a/src/applications/maniphest/editor/ManiphestEditEngine.php
+++ b/src/applications/maniphest/editor/ManiphestEditEngine.php
@@ -234,6 +234,7 @@ EODOCS
       $fields[] = id(new PhabricatorPointsEditField())
         ->setKey('points')
         ->setLabel($points_label)
+        ->setBulkEditLabel($action_label)
         ->setDescription(pht('Point value of the task.'))
         ->setConduitDescription(pht('Change the task point value.'))
         ->setConduitTypeDescription(pht('New task point value.'))
diff --git a/src/applications/transactions/bulk/type/BulkPointsParameterType.php b/src/applications/transactions/bulk/type/BulkPointsParameterType.php
new file mode 100644
index 0000000000..fe01db976a
--- /dev/null
+++ b/src/applications/transactions/bulk/type/BulkPointsParameterType.php
@@ -0,0 +1,10 @@
+<?php
+
+final class BulkPointsParameterType
+  extends BulkParameterType {
+
+  public function getPHUIXControlType() {
+    return 'points';
+  }
+
+}
diff --git a/src/applications/transactions/editfield/PhabricatorPointsEditField.php b/src/applications/transactions/editfield/PhabricatorPointsEditField.php
index 48c1b3b35b..a8c6d345f3 100644
--- a/src/applications/transactions/editfield/PhabricatorPointsEditField.php
+++ b/src/applications/transactions/editfield/PhabricatorPointsEditField.php
@@ -14,4 +14,9 @@ final class PhabricatorPointsEditField
   protected function newCommentAction() {
     return id(new PhabricatorEditEnginePointsCommentAction());
   }
+
+  protected function newBulkParameterType() {
+    return new BulkPointsParameterType();
+  }
+
 }