revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Modernize Facebook OAuth instructions

Browse source 
Summary: Ref T4593. We have somewhat outdated instructions, and safer setup instructions are now available.

Test Plan: Read instructions.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Maniphest Tasks: T4593

Differential Revision: https://secure.phabricator.com/D8518
This commit is contained in:
epriestley 2014-03-13 13:00:47 -07:00
parent ae7324fd5b
commit a9f38e55e5
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/applications/auth/provider/PhabricatorAuthProviderOAuthFacebook.php
View file

@ -10,7 +10,7 @@ final class PhabricatorAuthProviderOAuthFacebook
} }
public function getConfigurationHelp() { public function getConfigurationHelp() {
$uri = new PhutilURI(PhabricatorEnv::getProductionURI('/')); $uri = PhabricatorEnv::getProductionURI($this->getLoginURI());
return pht( return pht(
'To configure Facebook OAuth, create a new Facebook Application here:'. 'To configure Facebook OAuth, create a new Facebook Application here:'.
"\n\n". "\n\n".
@ -18,14 +18,16 @@ final class PhabricatorAuthProviderOAuthFacebook
"\n\n". "\n\n".
'You should use these settings in your application:'. 'You should use these settings in your application:'.
"\n\n". "\n\n".
" - **Site URL**: Set this to your full domain with protocol. For ". " - **Site URL**: Set this to `%s`\n".
" this Phabricator install, the correct value is: `%s`\n". " - **Valid OAuth redirect URIs**: You should also set this to `%s`\n".
" - **Site Domain**: Set this to the full domain without a protocol. ". " - **Client OAuth Login**: Set this to **OFF**.\n".
" For this Phabricator install, the correct value is: `%s`\n\n". " - **Embedded browser OAuth Login**: Set this to **OFF**.\n".
"\n\n".
"Some of these settings may be in the **Advanced** tab.\n\n".
"After creating your new application, copy the **App ID** and ". "After creating your new application, copy the **App ID** and ".
"**App Secret** to the fields above.", "**App Secret** to the fields above.",
(string)$uri, (string)$uri,
$uri->getDomain()); (string)$uri);
} }
public function getDefaultProviderConfig() { public function getDefaultProviderConfig() {