Update diff highlight colors for better color blindess distinction

Summary: Tweaks the diff colors here a bit, as well as making full diffs slightly easier to read in full. Ref T12060

Test Plan:
Tested prose diffs, email prose diffs, and a regular Differential revision.

{F2304056}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12060

Differential Revision: https://secure.phabricator.com/D17138

resources/celerity/map.php

@@ -12,7 +12,7 @@ return array(
     'core.pkg.css' => '9c725fa0',
     'core.pkg.js' => 'f998932d',
     'darkconsole.pkg.js' => 'e7393ebb',
-    'differential.pkg.css' => 'a4ba74b5',
+    'differential.pkg.css' => '13726e1c',
     'differential.pkg.js' => '40b18f35',
     'diffusion.pkg.css' => '91c5d3a6',
     'diffusion.pkg.js' => '84c8f8fd',
@@ -59,7 +59,7 @@ return array(
     'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127',
     'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
     'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
-    'rsrc/css/application/differential/changeset-view.css' => 'b158cc46',
+    'rsrc/css/application/differential/changeset-view.css' => '6d0fc277',
     'rsrc/css/application/differential/core.css' => '5b7b8ff4',
     'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e',
     'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
@@ -574,7 +574,7 @@ return array(
     'conpherence-thread-manager' => 'c8b5ee6f',
     'conpherence-transaction-css' => '85129c68',
     'd3' => 'a11a5ff2',
-    'differential-changeset-view-css' => 'b158cc46',
+    'differential-changeset-view-css' => '6d0fc277',
     'differential-core-view-css' => '5b7b8ff4',
     'differential-inline-comment-editor' => '2e3f9738',
     'differential-revision-add-comment-css' => 'c47f8c40',
@@ -1455,6 +1455,9 @@ return array(
       'javelin-install',
       'javelin-util',
     ),
+    '6d0fc277' => array(
+      'phui-inline-comment-view-css',
+    ),
     '6d3e1947' => array(
       'javelin-behavior',
       'javelin-diffusion-locate-file-source',
@@ -1858,9 +1861,6 @@ return array(
       'javelin-util',
       'phabricator-shaped-request',
     ),
-    'b158cc46' => array(
-      'phui-inline-comment-view-css',
-    ),
     'b1f0ccee' => array(
       'javelin-install',
       'javelin-dom',

src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php

@@ -21,15 +21,15 @@ final class PhabricatorApplicationTransactionTextDiffDetailView
 
     $old_styles = array(
       'padding: 0 2px;',
-      'color: #802b2b;',
-      'background: rgba(251, 175, 175, .7);',
+      'color: #333333;',
+      'background: #f8cbcb;',
     );
     $old_styles = implode(' ', $old_styles);
 
     $new_styles = array(
       'padding: 0 2px;',
-      'color: #3e6d35;',
-      'background: rgba(151, 234, 151, .6);',
+      'color: #333333;',
+      'background: #a6f3a6;',
     );
     $new_styles = implode(' ', $new_styles);
 

webroot/rsrc/css/application/differential/changeset-view.css

@@ -108,12 +108,9 @@
   padding: 0 2px;
 }
 
-.prose-diff span.old {
-  color: {$redtext};
-}
-
+.prose-diff span.old,
 .prose-diff span.new {
-  color: {$greentext};
+  color: {$darkgreytext};
 }
 
 .differential-diff th.selected {
@@ -124,12 +121,14 @@
   cursor: auto;
 }
 
-.differential-diff td.old {
-  background: rgba(251, 175, 175, .3);
+.differential-diff td.old,
+.differential-diff td.old-full {
+  background: #ffecec;
 }
 
-.differential-diff td.new {
-  background: rgba(151, 234, 151, .3);
+.differential-diff td.new,
+.differential-diff td.new-full {
+  background: #eaffea;
 }
 
 .differential-diff td.old-rebase {
@@ -140,16 +139,14 @@
   background: #eeffee;
 }
 
-.differential-diff td.old-full,
 .differential-diff td.old span.bright,
 .prose-diff span.old {
-  background: rgba(251, 175, 175, .7);
+  background: #f8cbcb;
 }
 
-.differential-diff td.new-full,
 .differential-diff td.new span.bright,
 .prose-diff span.new {
-  background: rgba(151, 234, 151, .6);
+  background: #a6f3a6;
 }
 
 .differential-diff td.copy {