From ab467d52f4dd7be9b137cab533cec7b155547fe9 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 5 Feb 2019 07:16:56 -0800 Subject: [PATCH] Improve feed rendering of user rename story Summary: Ref T13244. This story publishes to the feed (and I think that's reasonable and desirable) but doesn't render as nicely as it could. Improve the rendering. (See T9233 for some context on why we render stories like this one in this way.) Test Plan: {F6184490} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13244 Differential Revision: https://secure.phabricator.com/D20097 --- .../xaction/PhabricatorUserUsernameTransaction.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/applications/people/xaction/PhabricatorUserUsernameTransaction.php b/src/applications/people/xaction/PhabricatorUserUsernameTransaction.php index b6d23b3511..f2226d0010 100644 --- a/src/applications/people/xaction/PhabricatorUserUsernameTransaction.php +++ b/src/applications/people/xaction/PhabricatorUserUsernameTransaction.php @@ -40,6 +40,15 @@ final class PhabricatorUserUsernameTransaction $this->renderNewValue()); } + public function getTitleForFeed() { + return pht( + '%s renamed %s from %s to %s.', + $this->renderAuthor(), + $this->renderObject(), + $this->renderOldValue(), + $this->renderNewValue()); + } + public function validateTransactions($object, array $xactions) { $actor = $this->getActor(); $errors = array();