From ab63b1b2ae348be19ac3f7315de43bd2570a568b Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 12 Apr 2016 19:25:00 -0700 Subject: [PATCH] (stable) Fix Passphrase Credential dialog Summary: Fixes T10772, not sure why this fails, but reverting the code back to old dialog call works. Test Plan: - Try to add a new credential when importing a repository. - Also created a new credential normally, via Passphrase. - Also edited a credential. Reviewers: chad Reviewed By: chad Subscribers: Korvin Maniphest Tasks: T10772 Differential Revision: https://secure.phabricator.com/D15691 --- .../controller/PassphraseCredentialEditController.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/applications/passphrase/controller/PassphraseCredentialEditController.php b/src/applications/passphrase/controller/PassphraseCredentialEditController.php index 4aa687ddc1..a814b5dc72 100644 --- a/src/applications/passphrase/controller/PassphraseCredentialEditController.php +++ b/src/applications/passphrase/controller/PassphraseCredentialEditController.php @@ -21,6 +21,7 @@ final class PassphraseCredentialEditController extends PassphraseController { } $type = $this->getCredentialType($credential->getCredentialType()); + $type_const = $type->getCredentialType(); $is_new = false; } else { @@ -228,6 +229,7 @@ final class PassphraseCredentialEditController extends PassphraseController { $form = id(new AphrontFormView()) ->setUser($viewer) ->addHiddenInput('isInitialized', true) + ->addHiddenInput('type', $type_const) ->appendChild( id(new AphrontFormTextControl()) ->setName('name')