revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exceptions which block adding Dashboard to Project Menu

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15339

Test Plan: Applied these four changes and `/dashboard/install/1/project/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15339

Differential Revision: https://we.phorge.it/D25184
This commit is contained in:
Andre Klapper 2023-05-06 04:03:37 +02:00
parent a3861edc19
commit ab69bcccd9
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php
View file

@ -17,16 +17,16 @@ abstract class PhabricatorDashboardObjectInstallWorkflow
$target_identifier = head($target_tokens); $target_identifier = head($target_tokens);
} }
if (!strlen($target_identifier)) { if (!phutil_nonempty_string($target_identifier)) {
$target_identifier = $request->getStr('target'); $target_identifier = $request->getStr('target');
} }
if (!strlen($target_identifier)) { if (!phutil_nonempty_string($target_identifier)) {
$target_identifier = $this->getMode(); $target_identifier = $this->getMode();
} }
$target = null; $target = null;
if (strlen($target_identifier)) { if (phutil_nonempty_string($target_identifier)) {
$targets = array(); $targets = array();
if (ctype_digit($target_identifier)) { if (ctype_digit($target_identifier)) {
@ -74,7 +74,7 @@ abstract class PhabricatorDashboardObjectInstallWorkflow
} }
$errors = array(); $errors = array();
if (strlen($target_identifier)) { if (phutil_nonempty_string($target_identifier)) {
if (!$target) { if (!$target) {
$errors[] = pht('Choose a valid object.'); $errors[] = pht('Choose a valid object.');
} else if (!$can_edit) { } else if (!$can_edit) {