From ab748e522aa3387a078834005c8ad5589b1320bc Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 15 Dec 2015 06:13:48 -0800 Subject: [PATCH] Fix an issue with the Spaces EditField not reading values properly Summary: Fixes T9988. This logic got inverted by accident at some point. Test Plan: - Edited a task, shifting spaces. - Created a task in default space. - Created a task in custom space. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9988 Differential Revision: https://secure.phabricator.com/D14787 --- .../policy/editor/PhabricatorPolicyEditEngineExtension.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php b/src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php index d7fe2e4d6f..57720b3ba7 100644 --- a/src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php +++ b/src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php @@ -91,7 +91,7 @@ final class PhabricatorPolicyEditEngineExtension ->setValue($object->getPolicy($capability)); $fields[] = $policy_field; - if (!($object instanceof PhabricatorSpacesInterface)) { + if ($object instanceof PhabricatorSpacesInterface) { if ($capability == PhabricatorPolicyCapability::CAN_VIEW) { $type_space = PhabricatorTransactions::TYPE_SPACE; if (isset($types[$type_space])) {