From aba7c98baedb67e3d8042eb7970b908101db6aa1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 5 Jun 2019 11:41:36 -0700 Subject: [PATCH] Skip loading transaction handles in an old migration Summary: Ref T13305. See that task for discussion. This old migration may indirectly cause search index worker tasks to queue by loading handles. They'll fail since we later added `dateCreated` to the worker task table. Use `needHandles(false)` (since we don't use them) to disable loading handles and avoid the problem. Test Plan: - Ran `bin/storage upgrade -f` on an older instance (late 2016) and hit this issue. - Applied the patch, got a clean migration to modernity. Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13305 Differential Revision: https://secure.phabricator.com/D20570 --- resources/sql/autopatches/20180208.maniphest.02.populate.php | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/sql/autopatches/20180208.maniphest.02.populate.php b/resources/sql/autopatches/20180208.maniphest.02.populate.php index e11267496c..4b4e549574 100644 --- a/resources/sql/autopatches/20180208.maniphest.02.populate.php +++ b/resources/sql/autopatches/20180208.maniphest.02.populate.php @@ -26,6 +26,7 @@ foreach (new LiskMigrationIterator($table) as $task) { $xactions = id(new ManiphestTransactionQuery()) ->setViewer($viewer) ->withObjectPHIDs(array($task->getPHID())) + ->needHandles(false) ->withTransactionTypes( array( $type_merge,