revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 19:22:42 +01:00
Code Issues Releases Wiki Activity

Skip loading transaction handles in an old migration

Browse source 
Summary:
Ref T13305. See that task for discussion.

This old migration may indirectly cause search index worker tasks to queue by loading handles. They'll fail since we later added `dateCreated` to the worker task table.

Use `needHandles(false)` (since we don't use them) to disable loading handles and avoid the problem.

Test Plan:
  - Ran `bin/storage upgrade -f` on an older instance (late 2016) and hit this issue.
  - Applied the patch, got a clean migration to modernity.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13305

Differential Revision: https://secure.phabricator.com/D20570
This commit is contained in:
epriestley 2019-06-05 11:41:36 -07:00
parent bab35f28e4
commit aba7c98bae
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
resources/sql/autopatches/20180208.maniphest.02.populate.php
View file

@ -26,6 +26,7 @@ foreach (new LiskMigrationIterator($table) as $task) {
$xactions = id(new ManiphestTransactionQuery()) $xactions = id(new ManiphestTransactionQuery())
->setViewer($viewer) ->setViewer($viewer)
->withObjectPHIDs(array($task->getPHID())) ->withObjectPHIDs(array($task->getPHID()))
->needHandles(false)
->withTransactionTypes( ->withTransactionTypes(
array( array(
$type_merge, $type_merge,