From abb4c03b476d4159ebff62ed44009c0e4fec3be1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 5 Mar 2016 14:53:44 -0800 Subject: [PATCH] Remove shouldShowSubscribersProperty() from SubscribableInterface Summary: Every caller returns `true`. This was added a long time ago for Projects, but projects are no longer subscribable. I don't anticipate needing this in the future. Test Plan: Grepped for this method. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15409 --- .../badges/storage/PhabricatorBadgesBadge.php | 4 ---- .../calendar/storage/PhabricatorCalendarEvent.php | 4 ---- .../countdown/storage/PhabricatorCountdown.php | 3 --- .../differential/storage/DifferentialRevision.php | 4 ---- src/applications/files/storage/PhabricatorFile.php | 4 ---- src/applications/fund/storage/FundInitiative.php | 4 ---- .../storage/configuration/HarbormasterBuildPlan.php | 4 ---- src/applications/herald/storage/HeraldRule.php | 4 ---- .../legalpad/storage/LegalpadDocument.php | 4 ---- .../macro/storage/PhabricatorFileImageMacro.php | 4 ---- .../maniphest/storage/ManiphestTask.php | 4 ---- .../passphrase/storage/PassphraseCredential.php | 4 ---- src/applications/paste/storage/PhabricatorPaste.php | 4 ---- src/applications/phame/storage/PhameBlog.php | 4 ---- src/applications/phame/storage/PhamePost.php | 4 ---- src/applications/pholio/storage/PholioMock.php | 4 ---- .../phriction/storage/PhrictionDocument.php | 3 --- .../phurl/storage/PhabricatorPhurlURL.php | 3 --- src/applications/ponder/storage/PonderAnswer.php | 4 ---- src/applications/ponder/storage/PonderQuestion.php | 4 ---- .../storage/PhabricatorRepositoryCommit.php | 4 ---- .../slowvote/storage/PhabricatorSlowvotePoll.php | 4 ---- .../PhabricatorSubscriptionsUIEventListener.php | 5 ----- .../interface/PhabricatorSubscribableInterface.php | 13 ------------- .../workers/storage/PhabricatorWorkerBulkJob.php | 4 ---- 25 files changed, 107 deletions(-) diff --git a/src/applications/badges/storage/PhabricatorBadgesBadge.php b/src/applications/badges/storage/PhabricatorBadgesBadge.php index 254b02a6eb..d32a46a803 100644 --- a/src/applications/badges/storage/PhabricatorBadgesBadge.php +++ b/src/applications/badges/storage/PhabricatorBadgesBadge.php @@ -181,10 +181,6 @@ final class PhabricatorBadgesBadge extends PhabricatorBadgesDAO return ($this->creatorPHID == $phid); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php index 36aa905b3e..8432a157e2 100644 --- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php +++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php @@ -531,10 +531,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO return ($phid == $this->getUserPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ diff --git a/src/applications/countdown/storage/PhabricatorCountdown.php b/src/applications/countdown/storage/PhabricatorCountdown.php index 1a864907eb..52a395f0c2 100644 --- a/src/applications/countdown/storage/PhabricatorCountdown.php +++ b/src/applications/countdown/storage/PhabricatorCountdown.php @@ -70,9 +70,6 @@ final class PhabricatorCountdown extends PhabricatorCountdownDAO return ($phid == $this->getAuthorPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } /* -( PhabricatorApplicationTransactionInterface )------------------------- */ diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php index e67208c53a..6ca586c747 100644 --- a/src/applications/differential/storage/DifferentialRevision.php +++ b/src/applications/differential/storage/DifferentialRevision.php @@ -485,10 +485,6 @@ final class DifferentialRevision extends DifferentialDAO return false; } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorCustomFieldInterface )------------------------------------ */ diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php index 7d2780778f..28328796ce 100644 --- a/src/applications/files/storage/PhabricatorFile.php +++ b/src/applications/files/storage/PhabricatorFile.php @@ -1348,10 +1348,6 @@ final class PhabricatorFile extends PhabricatorFileDAO return ($this->authorPHID == $phid); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ diff --git a/src/applications/fund/storage/FundInitiative.php b/src/applications/fund/storage/FundInitiative.php index 3375551443..517c377c44 100644 --- a/src/applications/fund/storage/FundInitiative.php +++ b/src/applications/fund/storage/FundInitiative.php @@ -178,10 +178,6 @@ final class FundInitiative extends FundDAO return ($phid == $this->getOwnerPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorTokenRecevierInterface )---------------------------------- */ diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php index c5b2142ac5..8d706657ef 100644 --- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php +++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php @@ -127,10 +127,6 @@ final class HarbormasterBuildPlan extends HarbormasterDAO return false; } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorApplicationTransactionInterface )------------------------- */ diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php index 8d585263c0..9902e952ef 100644 --- a/src/applications/herald/storage/HeraldRule.php +++ b/src/applications/herald/storage/HeraldRule.php @@ -328,10 +328,6 @@ final class HeraldRule extends HeraldDAO return $this->isPersonalRule() && $phid == $this->getAuthorPHID(); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorDestructibleInterface )----------------------------------- */ diff --git a/src/applications/legalpad/storage/LegalpadDocument.php b/src/applications/legalpad/storage/LegalpadDocument.php index 51f158a978..fcecac991f 100644 --- a/src/applications/legalpad/storage/LegalpadDocument.php +++ b/src/applications/legalpad/storage/LegalpadDocument.php @@ -163,10 +163,6 @@ final class LegalpadDocument extends LegalpadDAO return ($this->creatorPHID == $phid); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorPolicyInterface )----------------------------------------- */ diff --git a/src/applications/macro/storage/PhabricatorFileImageMacro.php b/src/applications/macro/storage/PhabricatorFileImageMacro.php index 5cf23133a3..37f0d5c06b 100644 --- a/src/applications/macro/storage/PhabricatorFileImageMacro.php +++ b/src/applications/macro/storage/PhabricatorFileImageMacro.php @@ -111,10 +111,6 @@ final class PhabricatorFileImageMacro extends PhabricatorFileDAO return false; } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorTokenRecevierInterface )---------------------------------- */ diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php index 0c1a1bc787..7718bdfcf8 100644 --- a/src/applications/maniphest/storage/ManiphestTask.php +++ b/src/applications/maniphest/storage/ManiphestTask.php @@ -269,10 +269,6 @@ final class ManiphestTask extends ManiphestDAO return ($phid == $this->getOwnerPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( Markup Interface )--------------------------------------------------- */ diff --git a/src/applications/passphrase/storage/PassphraseCredential.php b/src/applications/passphrase/storage/PassphraseCredential.php index f263523b49..8384f5bd52 100644 --- a/src/applications/passphrase/storage/PassphraseCredential.php +++ b/src/applications/passphrase/storage/PassphraseCredential.php @@ -157,10 +157,6 @@ final class PassphraseCredential extends PassphraseDAO return false; } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorDestructibleInterface )----------------------------------- */ diff --git a/src/applications/paste/storage/PhabricatorPaste.php b/src/applications/paste/storage/PhabricatorPaste.php index 624c70c410..bc0909cd45 100644 --- a/src/applications/paste/storage/PhabricatorPaste.php +++ b/src/applications/paste/storage/PhabricatorPaste.php @@ -155,10 +155,6 @@ final class PhabricatorPaste extends PhabricatorPasteDAO return ($this->authorPHID == $phid); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ diff --git a/src/applications/phame/storage/PhameBlog.php b/src/applications/phame/storage/PhameBlog.php index d9b9bdb41d..861def127b 100644 --- a/src/applications/phame/storage/PhameBlog.php +++ b/src/applications/phame/storage/PhameBlog.php @@ -336,10 +336,6 @@ final class PhameBlog extends PhameDAO return ($this->creatorPHID == $phid); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorConduitResultInterface )---------------------------------- */ diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php index 01dd71e88d..fb2e8058dc 100644 --- a/src/applications/phame/storage/PhamePost.php +++ b/src/applications/phame/storage/PhamePost.php @@ -282,10 +282,6 @@ final class PhamePost extends PhameDAO return ($this->bloggerPHID == $phid); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorConduitResultInterface )---------------------------------- */ diff --git a/src/applications/pholio/storage/PholioMock.php b/src/applications/pholio/storage/PholioMock.php index c817b7f32b..49cf2ace5d 100644 --- a/src/applications/pholio/storage/PholioMock.php +++ b/src/applications/pholio/storage/PholioMock.php @@ -184,10 +184,6 @@ final class PholioMock extends PholioDAO return ($this->authorPHID == $phid); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorPolicyInterface Implementation )-------------------------- */ diff --git a/src/applications/phriction/storage/PhrictionDocument.php b/src/applications/phriction/storage/PhrictionDocument.php index 915cfed1eb..f931ac8dbe 100644 --- a/src/applications/phriction/storage/PhrictionDocument.php +++ b/src/applications/phriction/storage/PhrictionDocument.php @@ -194,9 +194,6 @@ final class PhrictionDocument extends PhrictionDAO return false; } - public function shouldShowSubscribersProperty() { - return true; - } /* -( PhabricatorApplicationTransactionInterface )------------------------- */ diff --git a/src/applications/phurl/storage/PhabricatorPhurlURL.php b/src/applications/phurl/storage/PhabricatorPhurlURL.php index 30a3b0b93b..19d5968b0c 100644 --- a/src/applications/phurl/storage/PhabricatorPhurlURL.php +++ b/src/applications/phurl/storage/PhabricatorPhurlURL.php @@ -169,9 +169,6 @@ final class PhabricatorPhurlURL extends PhabricatorPhurlDAO return ($phid == $this->getAuthorPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ diff --git a/src/applications/ponder/storage/PonderAnswer.php b/src/applications/ponder/storage/PonderAnswer.php index 025c020637..76c9057497 100644 --- a/src/applications/ponder/storage/PonderAnswer.php +++ b/src/applications/ponder/storage/PonderAnswer.php @@ -219,10 +219,6 @@ final class PonderAnswer extends PonderDAO return ($phid == $this->getAuthorPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorDestructibleInterface )----------------------------------- */ diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php index 5ab719e3ac..99ce64c9f7 100644 --- a/src/applications/ponder/storage/PonderQuestion.php +++ b/src/applications/ponder/storage/PonderQuestion.php @@ -248,10 +248,6 @@ final class PonderQuestion extends PonderDAO return ($phid == $this->getAuthorPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php index 9fd218db9a..18732e5e4c 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php +++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php @@ -443,10 +443,6 @@ final class PhabricatorRepositoryCommit return ($phid == $this->getAuthorPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorApplicationTransactionInterface )------------------------- */ diff --git a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php index 2240c510aa..6896f7ba2f 100644 --- a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php +++ b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php @@ -179,10 +179,6 @@ final class PhabricatorSlowvotePoll extends PhabricatorSlowvoteDAO return ($phid == $this->getAuthorPHID()); } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ diff --git a/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php b/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php index b69ce4243f..acbb978238 100644 --- a/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php +++ b/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php @@ -96,11 +96,6 @@ final class PhabricatorSubscriptionsUIEventListener return; } - if (!$object->shouldShowSubscribersProperty()) { - // This object doesn't render subscribers in its property list. - return; - } - $subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID( $object->getPHID()); if ($subscribers) { diff --git a/src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php b/src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php index e54e2cd42e..1af9e7107f 100644 --- a/src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php +++ b/src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php @@ -13,15 +13,6 @@ interface PhabricatorSubscribableInterface { */ public function isAutomaticallySubscribed($phid); - - /** - * Return `true` to indicate that "Subscribers:" should be shown when - * rendering property lists for this object, or `false` to omit the property. - * - * @return bool True to show the "Subscribers:" property. - */ - public function shouldShowSubscribersProperty(); - } // TEMPLATE IMPLEMENTATION ///////////////////////////////////////////////////// @@ -33,8 +24,4 @@ interface PhabricatorSubscribableInterface { return false; } - public function shouldShowSubscribersProperty() { - return true; - } - */ diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php index 0b70268cb4..ca7508d2b2 100644 --- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php +++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php @@ -218,10 +218,6 @@ final class PhabricatorWorkerBulkJob return false; } - public function shouldShowSubscribersProperty() { - return true; - } - /* -( PhabricatorApplicationTransactionInterface )------------------------- */