revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Display correct size of binary files in Diffusion

Browse source 
Test Plan: https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/image/header_logo.png

Reviewers: btrahan, epriestley

Reviewed By: btrahan

CC: aran, Korvin

Maniphest Tasks: T1139

Differential Revision: https://secure.phabricator.com/D3961
This commit is contained in:
vrana 2012-11-12 16:35:26 -08:00
parent ede1f4721f
commit abd880e30f
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/diffusion/controller/DiffusionBrowseFileController.php
View file

@ -885,9 +885,11 @@ final class DiffusionBrowseFileController extends DiffusionController {
private function buildBinaryCorpus($file_uri, $data) {
$properties = new PhabricatorPropertyListView();
$size = strlen($data);
$properties->addTextContent(
pht('This is a binary file. It is %d bytes in length.',
number_format(strlen($data)))
pht('This is a binary file. It is %2$s byte(s) in length.',
$size,
PhutilTranslator::getInstance()->formatNumber($size))
);
$actions = id(new PhabricatorActionListView())

5
src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php
View file

@ -167,6 +167,11 @@ abstract class PhabricatorBaseEnglishTranslation
'%d Lint Messages',
),
'This is a binary file. It is %2$s byte(s) in length.' => array(
'This is a binary file. It is %2$s byte in length.',
'This is a binary file. It is %2$s bytes in length.',
),
);
}