mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-18 21:02:41 +01:00
Update Maniphest "Reports" to base UI
Summary: Replace PanelView with ObjBox. Make burnup chart look less hated. Test Plan: Test a project, non project, various layouts on Maniphest Reports {F163644} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9397
This commit is contained in:
parent
93f68a07e4
commit
ac2b91711f
1 changed files with 16 additions and 7 deletions
|
@ -258,9 +258,17 @@ final class ManiphestReportController extends ManiphestController {
|
||||||
$caption = null;
|
$caption = null;
|
||||||
}
|
}
|
||||||
|
|
||||||
$panel = new AphrontPanelView();
|
if ($caption) {
|
||||||
$panel->setHeader($header);
|
$caption = id(new AphrontErrorView())
|
||||||
$panel->setCaption($caption);
|
->appendChild($caption)
|
||||||
|
->setSeverity(AphrontErrorView::SEVERITY_NOTICE);
|
||||||
|
}
|
||||||
|
|
||||||
|
$panel = new PHUIObjectBoxView();
|
||||||
|
$panel->setHeaderText($header);
|
||||||
|
if ($caption) {
|
||||||
|
$panel->setErrorView($caption);
|
||||||
|
}
|
||||||
$panel->appendChild($table);
|
$panel->appendChild($table);
|
||||||
|
|
||||||
$tokens = array();
|
$tokens = array();
|
||||||
|
@ -275,8 +283,9 @@ final class ManiphestReportController extends ManiphestController {
|
||||||
'div',
|
'div',
|
||||||
array(
|
array(
|
||||||
'id' => $id,
|
'id' => $id,
|
||||||
'style' => 'border: 1px solid #6f6f6f; '.
|
'style' => 'border: 1px solid #BFCFDA; '.
|
||||||
'margin: 1em 2em; '.
|
'background-color: #fff; '.
|
||||||
|
'margin: 8px 16px; '.
|
||||||
'height: 400px; ',
|
'height: 400px; ',
|
||||||
),
|
),
|
||||||
'');
|
'');
|
||||||
|
@ -628,8 +637,8 @@ final class ManiphestReportController extends ManiphestController {
|
||||||
'closed',
|
'closed',
|
||||||
));
|
));
|
||||||
|
|
||||||
$panel = new AphrontPanelView();
|
$panel = new PHUIObjectBoxView();
|
||||||
$panel->setHeader($header);
|
$panel->setHeaderText($header);
|
||||||
$panel->appendChild($table);
|
$panel->appendChild($table);
|
||||||
|
|
||||||
$tokens = array();
|
$tokens = array();
|
||||||
|
|
Loading…
Reference in a new issue