revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
Code Issues Releases Wiki Activity

Fix overzealous transactions on dashboard panels

Browse source 
Summary: Fixes T10474. This had the same root cause as T10024 -- a missing call to `didSetValueFromStorage()` because of the way the fields work.

Test Plan:
  - Edited a text panel before change, without changing text: got silly transaction.
  - Made change, edited text panel without changing text, no transaction.
  - Made a real edit, got a good transaction.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10474

Differential Revision: https://secure.phabricator.com/D15391
This commit is contained in:
epriestley 2016-03-03 05:46:02 -08:00
parent 61c45e4927
commit ac72927832
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/dashboard/customfield/PhabricatorDashboardPanelCoreCustomField.php
View file

@ -21,6 +21,7 @@ final class PhabricatorDashboardPanelCoreCustomField
public function readValueFromObject(PhabricatorCustomFieldInterface $object) { public function readValueFromObject(PhabricatorCustomFieldInterface $object) {
$key = $this->getProxy()->getRawStandardFieldKey(); $key = $this->getProxy()->getRawStandardFieldKey();
$this->setValueFromStorage($object->getProperty($key)); $this->setValueFromStorage($object->getProperty($key));
$this->didSetValueFromStorage();
} }
public function applyApplicationTransactionInternalEffects( public function applyApplicationTransactionInternalEffects(