From acaa2e148f578dff279fc8b2614aaafe30026d72 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 2 Jun 2017 16:10:59 -0700
Subject: [PATCH] (stable) Fix an issue where Phriction moves to new locations
 would fail with a "content required" error

Summary:
Ref T12793. I'd like to understand exactly when we broke this, but this seems to be a minimal fix that shouldn't do anything surprising.

When you move document `/a/` to `/a/b/` and that path doesn't exist yet, the Content transaction currently fails because there's "no content". The content gets added later by the "move" transaction but this is implicit.

To make this work, just ignore the "missing field" error. This is a little roundabout but unlikely to break anything in weird ways.

Test Plan:
  - Moved document `/a/b/` to `/a/b/c/`.
  - Before patch: error about missing content.
  - After patch: move worked properly.

Reviewers: chad, amckinley

Reviewed By: amckinley

Maniphest Tasks: T12793

Differential Revision: https://secure.phabricator.com/D18069
---
 .../phriction/controller/PhrictionMoveController.php             | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/applications/phriction/controller/PhrictionMoveController.php b/src/applications/phriction/controller/PhrictionMoveController.php
index f25465c3c0..b82681f0a7 100644
--- a/src/applications/phriction/controller/PhrictionMoveController.php
+++ b/src/applications/phriction/controller/PhrictionMoveController.php
@@ -60,6 +60,7 @@ final class PhrictionMoveController extends PhrictionController {
         ->setActor($viewer)
         ->setContentSourceFromRequest($request)
         ->setContinueOnNoEffect(true)
+        ->setContinueOnMissingFields(true)
         ->setDescription($v_note);
 
       $xactions = array();