revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Allow "differential.createinline" to accept JSON "false" for "isNewFile"

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/error-creating-inline-comment-via-conduit-api/4535>. See T12678.

This API method currently does not accept a JSON "false", but reasonably should.

Test Plan:
  - Called method with "isNewFile: false".
    - Before: type error.
    - After: inline comment.

Differential Revision: https://secure.phabricator.com/D21522
This commit is contained in:
epriestley 2021-01-26 14:45:21 -08:00
parent ed86c42b26
commit acd767c7f3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php
View file

@ -100,7 +100,7 @@ final class DifferentialCreateInlineConduitAPIMethod
->setChangesetID($cid) ->setChangesetID($cid)
->setAuthorPHID($request->getUser()->getPHID()) ->setAuthorPHID($request->getUser()->getPHID())
->setContent($request->getValue('content')) ->setContent($request->getValue('content'))
->setIsNewFile($request->getValue('isNewFile')) ->setIsNewFile((int)$request->getValue('isNewFile'))
->setLineNumber($request->getValue('lineNumber')) ->setLineNumber($request->getValue('lineNumber'))
->setLineLength($request->getValue('lineLength', 0)) ->setLineLength($request->getValue('lineLength', 0))
->save(); ->save();