Made Changes to Mock and File generation after pushing some methods to superclass

Summary: Ref T2903

Test Plan: Generation working properly. Was broken before.

Reviewers: epriestley

CC: AnhNhan, aran, Korvin

Maniphest Tasks: T2903

Differential Revision: https://secure.phabricator.com/D5844

src/applications/files/lipsum/PhabricatorFileTestDataGenerator.php

@@ -4,7 +4,7 @@ final class PhabricatorFileTestDataGenerator
   extends PhabricatorTestDataGenerator {
 
   public function generate() {
-    $authorPHID = $this->loadAuthorPHID();
+    $authorPHID = $this->loadPhabrictorUserPHID();
     $dimension = 1 << rand(5, 12);
     $image = id(new PhabricatorLipsumMondrianArtist())
       ->generate($dimension, $dimension);
@@ -17,12 +17,4 @@ final class PhabricatorFileTestDataGenerator
     $file->setMimeType('image/jpeg');
     return $file->save();
   }
-
-  private function loadPhabrictorUserPHID() {
-    return $this->loadOneRandom("PhabricatorUser")->getPHID();
-  }
-
-  public function loadAuthorPHID() {
-    return $this->loadPhabrictorUserPHID();
-  }
 }

src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php

@@ -65,10 +65,6 @@ final class PhabricatorPholioMockTestDataGenerator
     return $mock->save();
   }
 
-  public function loadPhabrictorUserPHID() {
-    return $this->loadOneRandom("PhabricatorUser")->getPHID();
-  }
-
   public function generateTitle() {
     return id(new PhutilLipsumContextFreeGrammar())
       ->generate();