From ad0052fcd643cb6b88453a6c8a11b5593056e154 Mon Sep 17 00:00:00 2001
From: Aviv Eyal <avivey@gmail.com>
Date: Fri, 18 Aug 2023 02:00:06 -0700
Subject: [PATCH] Rebrand: Add "path" entries to PlatformSymbols

Summary: Ref T15006. Change a few places that were mentioning `phabricator` path.

Test Plan: Mk1 eyeball on each effected page.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15006

Differential Revision: https://we.phorge.it/D25343
---
 .../controller/PhabricatorDaemonLogViewController.php      | 3 ++-
 .../controller/DiffusionRepositoryEditDeleteController.php | 3 ++-
 src/applications/metamta/PhabricatorMetaMTAWorker.php      | 7 ++++---
 .../repository/query/PhabricatorRepositoryQuery.php        | 4 ++++
 .../markup/markuprule/PhutilRemarkupEvalRule.php           | 4 ++--
 5 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/applications/daemon/controller/PhabricatorDaemonLogViewController.php b/src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
index f4c7ba60c9..253a3d5190 100644
--- a/src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
+++ b/src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
@@ -171,7 +171,8 @@ final class PhabricatorDaemonLogViewController
       phutil_tag(
         'tt',
         array(),
-        "phabricator/ $ ./bin/phd log --id {$id}"));
+        PlatformSymbols::getPlatformServerPath().
+        " $ ./bin/phd log --id {$id}"));
 
 
     return $view;
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php
index 93fe70c0fe..72e18d17e8 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php
@@ -28,7 +28,8 @@ final class DiffusionRepositoryEditDeleteController
           'the command line:'))
       ->appendCommand(
         csprintf(
-          'phabricator/ $ ./bin/remove destroy %R',
+          '%s $ ./bin/remove destroy %R',
+          PlatformSymbols::getPlatformServerPath(),
           $repository->getMonogram()))
       ->appendParagraph(
         pht(
diff --git a/src/applications/metamta/PhabricatorMetaMTAWorker.php b/src/applications/metamta/PhabricatorMetaMTAWorker.php
index dcc6a8dc5e..7d7c51f8b2 100644
--- a/src/applications/metamta/PhabricatorMetaMTAWorker.php
+++ b/src/applications/metamta/PhabricatorMetaMTAWorker.php
@@ -45,9 +45,10 @@ final class PhabricatorMetaMTAWorker
   public function renderForDisplay(PhabricatorUser $viewer) {
     return phutil_tag(
       'pre',
-      array(
-      ),
-      'phabricator/ $ ./bin/mail show-outbound --id '.$this->getTaskData());
+      array(),
+      PlatformSymbols::getPlatformServerPath().
+      ' $ ./bin/mail show-outbound --id '.
+      $this->getTaskData());
   }
 
 }
diff --git a/src/applications/repository/query/PhabricatorRepositoryQuery.php b/src/applications/repository/query/PhabricatorRepositoryQuery.php
index 05b011e85a..17a46f7b62 100644
--- a/src/applications/repository/query/PhabricatorRepositoryQuery.php
+++ b/src/applications/repository/query/PhabricatorRepositoryQuery.php
@@ -62,6 +62,10 @@ final class PhabricatorRepositoryQuery
     $slugs = array();
 
     foreach ($identifiers as $identifier) {
+      if ($identifier === null) {
+        continue;
+      }
+
       if (ctype_digit((string)$identifier)) {
         $ids[$identifier] = $identifier;
         continue;
diff --git a/src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php b/src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php
index cb67041c62..a525924fff 100644
--- a/src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php
+++ b/src/infrastructure/markup/markuprule/PhutilRemarkupEvalRule.php
@@ -68,11 +68,11 @@ final class PhutilRemarkupEvalRule extends PhutilRemarkupRule {
           'platform' => array(
             'server' => array(
               'name' => PlatformSymbols::getPlatformServerName(),
-              'path' => pht('phabricator/'),
+              'path' => PlatformSymbols::getPlatformServerPath(),
             ),
             'client' => array(
               'name' => PlatformSymbols::getPlatformClientName(),
-              'path' => pht('arcanist/'),
+              'path' => PlatformSymbols::getPlatformClientPath(),
             ),
           ),
         ),