From ad238211075a13108bd7b9aa573c3cadcb565da4 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Fri, 11 Jan 2013 15:28:07 -0800 Subject: [PATCH] Normalize input heights across browsers. Summary: FF treats input height different than other browsers, removes that case. Test Plan: Test inputs in FF, Chrome, Safari. Reviewers: vrana Reviewed By: vrana CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D4406 --- src/__celerity_resource_map__.php | 84 +++++++++++++------------- webroot/rsrc/css/aphront/form-view.css | 4 +- 2 files changed, 43 insertions(+), 45 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 5219d4f343..1435b95477 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -632,7 +632,7 @@ celerity_register_resource_map(array( ), 'aphront-form-view-css' => array( - 'uri' => '/res/cd15aff5/rsrc/css/aphront/form-view.css', + 'uri' => '/res/ff83e503/rsrc/css/aphront/form-view.css', 'type' => 'css', 'requires' => array( @@ -3246,7 +3246,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - '367c20f1' => + '8b2ff76d' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -3291,7 +3291,7 @@ celerity_register_resource_map(array( 37 => 'phabricator-object-item-list-view-css', 38 => 'global-drag-and-drop-css', ), - 'uri' => '/res/pkg/367c20f1/core.pkg.css', + 'uri' => '/res/pkg/8b2ff76d/core.pkg.css', 'type' => 'css', ), '2921e259' => @@ -3480,19 +3480,19 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => 'ac211174', - 'aphront-crumbs-view-css' => '367c20f1', - 'aphront-dialog-view-css' => '367c20f1', - 'aphront-error-view-css' => '367c20f1', - 'aphront-form-view-css' => '367c20f1', + 'aphront-crumbs-view-css' => '8b2ff76d', + 'aphront-dialog-view-css' => '8b2ff76d', + 'aphront-error-view-css' => '8b2ff76d', + 'aphront-form-view-css' => '8b2ff76d', 'aphront-headsup-action-list-view-css' => '20933a11', - 'aphront-headsup-view-css' => '367c20f1', - 'aphront-list-filter-view-css' => '367c20f1', - 'aphront-pager-view-css' => '367c20f1', - 'aphront-panel-view-css' => '367c20f1', - 'aphront-table-view-css' => '367c20f1', - 'aphront-tokenizer-control-css' => '367c20f1', - 'aphront-tooltip-css' => '367c20f1', - 'aphront-typeahead-control-css' => '367c20f1', + 'aphront-headsup-view-css' => '8b2ff76d', + 'aphront-list-filter-view-css' => '8b2ff76d', + 'aphront-pager-view-css' => '8b2ff76d', + 'aphront-panel-view-css' => '8b2ff76d', + 'aphront-table-view-css' => '8b2ff76d', + 'aphront-tokenizer-control-css' => '8b2ff76d', + 'aphront-tooltip-css' => '8b2ff76d', + 'aphront-typeahead-control-css' => '8b2ff76d', 'differential-changeset-view-css' => '20933a11', 'differential-core-view-css' => '20933a11', 'differential-inline-comment-editor' => '76556a8f', @@ -3506,7 +3506,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => '20933a11', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => '367c20f1', + 'global-drag-and-drop-css' => '8b2ff76d', 'inline-comment-summary-css' => '20933a11', 'javelin-aphlict' => '2921e259', 'javelin-behavior' => 'fbeded59', @@ -3575,49 +3575,49 @@ celerity_register_resource_map(array( 'javelin-util' => 'fbeded59', 'javelin-vector' => 'fbeded59', 'javelin-workflow' => 'fbeded59', - 'lightbox-attachment-css' => '367c20f1', + 'lightbox-attachment-css' => '8b2ff76d', 'maniphest-task-summary-css' => 'ac211174', 'maniphest-transaction-detail-css' => 'ac211174', - 'phabricator-app-buttons-css' => '367c20f1', + 'phabricator-app-buttons-css' => '8b2ff76d', 'phabricator-busy' => '2921e259', 'phabricator-content-source-view-css' => '20933a11', - 'phabricator-core-buttons-css' => '367c20f1', - 'phabricator-core-css' => '367c20f1', - 'phabricator-crumbs-view-css' => '367c20f1', - 'phabricator-directory-css' => '367c20f1', + 'phabricator-core-buttons-css' => '8b2ff76d', + 'phabricator-core-css' => '8b2ff76d', + 'phabricator-crumbs-view-css' => '8b2ff76d', + 'phabricator-directory-css' => '8b2ff76d', 'phabricator-drag-and-drop-file-upload' => '76556a8f', 'phabricator-dropdown-menu' => '2921e259', 'phabricator-file-upload' => '2921e259', - 'phabricator-filetree-view-css' => '367c20f1', - 'phabricator-flag-css' => '367c20f1', - 'phabricator-form-view-css' => '367c20f1', - 'phabricator-header-view-css' => '367c20f1', - 'phabricator-jump-nav' => '367c20f1', + 'phabricator-filetree-view-css' => '8b2ff76d', + 'phabricator-flag-css' => '8b2ff76d', + 'phabricator-form-view-css' => '8b2ff76d', + 'phabricator-header-view-css' => '8b2ff76d', + 'phabricator-jump-nav' => '8b2ff76d', 'phabricator-keyboard-shortcut' => '2921e259', 'phabricator-keyboard-shortcut-manager' => '2921e259', - 'phabricator-main-menu-view' => '367c20f1', + 'phabricator-main-menu-view' => '8b2ff76d', 'phabricator-menu-item' => '2921e259', - 'phabricator-nav-view-css' => '367c20f1', + 'phabricator-nav-view-css' => '8b2ff76d', 'phabricator-notification' => '2921e259', - 'phabricator-notification-css' => '367c20f1', - 'phabricator-notification-menu-css' => '367c20f1', - 'phabricator-object-item-list-view-css' => '367c20f1', + 'phabricator-notification-css' => '8b2ff76d', + 'phabricator-notification-menu-css' => '8b2ff76d', + 'phabricator-object-item-list-view-css' => '8b2ff76d', 'phabricator-object-selector-css' => '20933a11', 'phabricator-paste-file-upload' => '2921e259', 'phabricator-prefab' => '2921e259', 'phabricator-project-tag-css' => 'ac211174', - 'phabricator-remarkup-css' => '367c20f1', + 'phabricator-remarkup-css' => '8b2ff76d', 'phabricator-shaped-request' => '76556a8f', - 'phabricator-side-menu-view-css' => '367c20f1', - 'phabricator-standard-page-view' => '367c20f1', + 'phabricator-side-menu-view-css' => '8b2ff76d', + 'phabricator-standard-page-view' => '8b2ff76d', 'phabricator-textareautils' => '2921e259', 'phabricator-tooltip' => '2921e259', - 'phabricator-transaction-view-css' => '367c20f1', - 'phabricator-zindex-css' => '367c20f1', - 'sprite-apps-large-css' => '367c20f1', - 'sprite-gradient-css' => '367c20f1', - 'sprite-icon-css' => '367c20f1', - 'sprite-menu-css' => '367c20f1', - 'syntax-highlighting-css' => '367c20f1', + 'phabricator-transaction-view-css' => '8b2ff76d', + 'phabricator-zindex-css' => '8b2ff76d', + 'sprite-apps-large-css' => '8b2ff76d', + 'sprite-gradient-css' => '8b2ff76d', + 'sprite-icon-css' => '8b2ff76d', + 'sprite-menu-css' => '8b2ff76d', + 'syntax-highlighting-css' => '8b2ff76d', ), )); diff --git a/webroot/rsrc/css/aphront/form-view.css b/webroot/rsrc/css/aphront/form-view.css index 121104e058..fb613f78b2 100644 --- a/webroot/rsrc/css/aphront/form-view.css +++ b/webroot/rsrc/css/aphront/form-view.css @@ -34,9 +34,7 @@ .aphront-form-control-text .aphront-form-input input, .aphront-form-control-password .aphront-form-input input { font-size: 13px; - height: 26px; - padding: 4px 6px; - line-height: 20px; + padding: 4px 4px; color: #333; vertical-align: middle; background-color: #ffffff;