1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-03 03:11:01 +01:00

Fix an issue with creating tasks directly into milestone columns

Summary:
These columns were conflating `projectPHID` (the defualt project to add to the task) with `boardPHID` (the board the column appears on).

Separate them to fix the beahvior.

Test Plan: Used "Add Task" from dropdown menu of a milestone column on a parent project's workboard.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15242
This commit is contained in:
epriestley 2016-02-11 09:51:32 -08:00
parent 705c8c956a
commit ad77b014f1
3 changed files with 15 additions and 14 deletions

View file

@ -418,7 +418,7 @@ return array(
'rsrc/js/application/projects/WorkboardBoard.js' => '52291776', 'rsrc/js/application/projects/WorkboardBoard.js' => '52291776',
'rsrc/js/application/projects/WorkboardCard.js' => 'c587b80f', 'rsrc/js/application/projects/WorkboardCard.js' => 'c587b80f',
'rsrc/js/application/projects/WorkboardColumn.js' => 'f05d6e5d', 'rsrc/js/application/projects/WorkboardColumn.js' => 'f05d6e5d',
'rsrc/js/application/projects/WorkboardController.js' => 'fa1378c3', 'rsrc/js/application/projects/WorkboardController.js' => '55baf5ed',
'rsrc/js/application/projects/behavior-project-boards.js' => '14a1faae', 'rsrc/js/application/projects/behavior-project-boards.js' => '14a1faae',
'rsrc/js/application/projects/behavior-project-create.js' => '065227cc', 'rsrc/js/application/projects/behavior-project-create.js' => '065227cc',
'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb', 'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb',
@ -729,7 +729,7 @@ return array(
'javelin-workboard-board' => '52291776', 'javelin-workboard-board' => '52291776',
'javelin-workboard-card' => 'c587b80f', 'javelin-workboard-card' => 'c587b80f',
'javelin-workboard-column' => 'f05d6e5d', 'javelin-workboard-column' => 'f05d6e5d',
'javelin-workboard-controller' => 'fa1378c3', 'javelin-workboard-controller' => '55baf5ed',
'javelin-workflow' => '5b2e3e2b', 'javelin-workflow' => '5b2e3e2b',
'lightbox-attachment-css' => '7acac05d', 'lightbox-attachment-css' => '7acac05d',
'maniphest-batch-editor' => 'b0f0b6d5', 'maniphest-batch-editor' => 'b0f0b6d5',
@ -1253,6 +1253,16 @@ return array(
'javelin-vector', 'javelin-vector',
'javelin-dom', 'javelin-dom',
), ),
'55baf5ed' => array(
'javelin-install',
'javelin-dom',
'javelin-util',
'javelin-vector',
'javelin-stratcom',
'javelin-workflow',
'phabricator-drag-and-drop-file-upload',
'javelin-workboard-board',
),
'56a1ca03' => array( '56a1ca03' => array(
'javelin-behavior', 'javelin-behavior',
'javelin-behavior-device', 'javelin-behavior-device',
@ -2098,16 +2108,6 @@ return array(
'javelin-vector', 'javelin-vector',
'javelin-magical-init', 'javelin-magical-init',
), ),
'fa1378c3' => array(
'javelin-install',
'javelin-dom',
'javelin-util',
'javelin-vector',
'javelin-stratcom',
'javelin-workflow',
'phabricator-drag-and-drop-file-upload',
'javelin-workboard-board',
),
'fb20ac8d' => array( 'fb20ac8d' => array(
'javelin-behavior', 'javelin-behavior',
'javelin-aphlict', 'javelin-aphlict',

View file

@ -720,6 +720,7 @@ final class PhabricatorProjectBoardViewController
->setMetadata( ->setMetadata(
array( array(
'columnPHID' => $column->getPHID(), 'columnPHID' => $column->getPHID(),
'boardPHID' => $project->getPHID(),
'projectPHID' => $default_phid, 'projectPHID' => $default_phid,
)); ));

View file

@ -158,14 +158,14 @@ JX.install('WorkboardController', {
var column_data = e.getNodeData('column-add-task'); var column_data = e.getNodeData('column-add-task');
var column_phid = column_data.columnPHID; var column_phid = column_data.columnPHID;
var board_phid = column_data.projectPHID; var board_phid = column_data.boardPHID;
var board = this._getBoard(board_phid); var board = this._getBoard(board_phid);
var column = board.getColumn(column_phid); var column = board.getColumn(column_phid);
var request_data = { var request_data = {
responseType: 'card', responseType: 'card',
columnPHID: column.getPHID(), columnPHID: column.getPHID(),
projects: board.getPHID(), projects: column_data.projectPHID,
visiblePHIDs: column.getCardPHIDs(), visiblePHIDs: column.getCardPHIDs(),
order: board.getOrder() order: board.getOrder()
}; };