ObjectBoxes for Diffusion

Summary: Two missed Object Box cases in Diffusion.

Test Plan: View an individual file in Diffusion

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D7187

src/applications/diffusion/controller/DiffusionBrowseController.php

@@ -190,13 +190,10 @@ abstract class DiffusionBrowseController extends DiffusionController {
     $handles = $this->loadViewerHandles($phids);
     $view->setHandles($handles);
 
-    $header = id(new PHUIHeaderView())
+    return id(new PHUIObjectBoxView())
-      ->setHeader(pht('Pending Differential Revisions'));
+      ->setHeaderText(pht('Pending Differential Revisions'))
+      ->appendChild($view);
 
-    return array(
-      $header,
-      $view,
-    );
   }
 
 }

src/applications/diffusion/controller/DiffusionBrowseFileController.php

@@ -98,23 +98,22 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
 
     require_celerity_resource('diffusion-source-css');
 
-    $object_box = id(new PHUIObjectBoxView())
-      ->setHeader($this->buildHeaderView($drequest))
-      ->setActionList($this->buildActionView($drequest))
-      ->setPropertyList($this->buildPropertyView($drequest));
-
     // Render the page.
-    $content = array();
-
-    $content[] = $this->buildHeaderView($drequest);
     $view = $this->buildActionView($drequest);
-    $content[] = $this->enrichActionView(
+    $action_list = $this->enrichActionView(
       $view,
       $drequest,
       $show_blame,
       $show_color,
       $binary_uri);
-    $content[] = $this->buildPropertyView($drequest);
+
+    $object_box = id(new PHUIObjectBoxView())
+      ->setHeader($this->buildHeaderView($drequest))
+      ->setActionList($action_list)
+      ->setPropertyList($this->buildPropertyView($drequest));
+
+    $content = array();
+    $content[] = $object_box;
 
     $follow  = $request->getStr('follow');
     if ($follow) {