From adcc063242e5987a22899b425db0d90c5f4f668b Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 25 Apr 2022 12:27:42 -0700 Subject: [PATCH] Fix a PHP 8.1 string strictness issue in repositories Summary: Ref T13588. This is a little too strict, as `$line` may be an integer. Test Plan: Will deploy Maniphest Tasks: T13588 Differential Revision: https://secure.phabricator.com/D21775 --- src/applications/repository/storage/PhabricatorRepository.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php index 8f02dd664f..fd10e076c1 100644 --- a/src/applications/repository/storage/PhabricatorRepository.php +++ b/src/applications/repository/storage/PhabricatorRepository.php @@ -757,6 +757,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO $commit = ';'.phutil_escape_uri($commit); } + $line = phutil_string_cast($line); if (phutil_nonempty_string($line)) { $line = '$'.phutil_escape_uri($line); }