Restyle remarkup file links

Summary: Removes the icon image, uses font awesome. Better spacing.

Test Plan: Attach files to task, see new layout. click file, click download.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T3612

Differential Revision: https://secure.phabricator.com/D16918

resources/celerity/map.php

@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => '0b64e988',
     'conpherence.pkg.js' => '6249a1cf',
-    'core.pkg.css' => '92233377',
+    'core.pkg.css' => '6ae56144',
     'core.pkg.js' => '519f84e8',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'a4ba74b5',
@@ -108,7 +108,7 @@ return array(
     'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
     'rsrc/css/application/uiexample/example.css' => '528b19de',
     'rsrc/css/core/core.css' => 'd0801452',
-    'rsrc/css/core/remarkup.css' => 'e70ca862',
+    'rsrc/css/core/remarkup.css' => '8e3d4635',
     'rsrc/css/core/syntax.css' => '769d3498',
     'rsrc/css/core/z-index.css' => 'd1270942',
     'rsrc/css/diviner/diviner-shared.css' => 'aa3656aa',
@@ -803,7 +803,7 @@ return array(
     'phabricator-object-selector-css' => '85ee8ce6',
     'phabricator-phtize' => 'd254d646',
     'phabricator-prefab' => '8d40ae75',
-    'phabricator-remarkup-css' => 'e70ca862',
+    'phabricator-remarkup-css' => '8e3d4635',
     'phabricator-search-results-css' => '7dea472c',
     'phabricator-shaped-request' => '7cbe244b',
     'phabricator-slowvote-css' => 'a94b7230',

src/view/layout/PhabricatorFileLinkView.php

@@ -97,6 +97,9 @@ final class PhabricatorFileLinkView extends AphrontView {
       $class = $this->getCustomClass();
     }
 
+    $icon = id(new PHUIIconView())
+      ->setIcon('fa-file-text-o');
+
     return javelin_tag(
       'a',
       array(
@@ -106,6 +109,9 @@ final class PhabricatorFileLinkView extends AphrontView {
         'meta'        => $meta,
         'mustcapture' => $mustcapture,
       ),
-      $this->getFileName());
+      array(
+        $icon,
+        $this->getFileName(),
+      ));
   }
 }

webroot/rsrc/css/core/remarkup.css

@@ -370,8 +370,22 @@ video.phabricator-media {
 }
 
 .phabricator-remarkup-embed-layout-link {
-  padding-left: 20px;
-  background: url(/rsrc/image/icon/fatcow/page_white_put.png) 0 0 no-repeat;
+  padding: 2px 0;
+  border-radius: 3px;
+  margin: 0;
+  display: inline-block;
+  font-weight: bold;
+  color: {$anchor};
+  -webkit-font-smoothing: antialiased;
+}
+
+.phabricator-remarkup-embed-layout-link .phui-icon-view {
+  margin-right: 8px;
+}
+
+.phabricator-remarkup-embed-layout-link:hover,
+.phabricator-remarkup-embed-layout-link:hover .phui-icon-view {
+  color: {$violet};
 }
 
 .phabricator-remarkup-embed-float-left {