revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-17 12:22:42 +01:00
Code Issues Releases Wiki Activity

Allow owners paths to be arbitrarily long and add storage for display paths

Browse source 
Summary:
Depends on D19182. Ref T11015. This changes `path` from `text255` to `longtext` because paths may be arbitrarily long.

It adds `pathDisplay` to prepare for display paths and storage paths having different values. For now, `pathDisplay` is copied from `path` and always has the same value.

Test Plan:
  - Ran migration, checked database for sanity (all `pathDisplay` and `path` values identical).
  - Added new paths, saw `pathDisplay` and `path` get the same values.
  - Added an unreasonably enormous path with far more than 255 characters.

Maniphest Tasks: T11015

Differential Revision: https://secure.phabricator.com/D19183
This commit is contained in:
epriestley 2018-03-06 19:50:09 -08:00
parent 8cb273a053
commit adde4089b4
4 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/sql/autopatches/20180306.opath.05.longpath.sql Normal file
View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_owners.owners_path
CHANGE path path LONGTEXT NOT NULL COLLATE {$COLLATE_TEXT};

2
resources/sql/autopatches/20180306.opath.06.pathdisplay.sql Normal file
View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_owners.owners_path
ADD pathDisplay LONGTEXT NOT NULL COLLATE {$COLLATE_TEXT};

2
resources/sql/autopatches/20180306.opath.07.copypaths.sql Normal file
View file

@ -0,0 +1,2 @@
UPDATE {$NAMESPACE}_owners.owners_path
SET pathDisplay = path WHERE pathDisplay = '';

5
src/applications/owners/storage/PhabricatorOwnersPath.php
View file

@ -6,6 +6,7 @@ final class PhabricatorOwnersPath extends PhabricatorOwnersDAO {
protected $repositoryPHID;
protected $pathIndex;
protected $path;
protected $pathDisplay;
protected $excluded;
private $fragments;
@ -15,7 +16,8 @@ final class PhabricatorOwnersPath extends PhabricatorOwnersDAO {
return array(
self::CONFIG_TIMESTAMPS => false,
self::CONFIG_COLUMN_SCHEMA => array(
'path' => 'text255',
'path' => 'text',
'pathDisplay' => 'text',
'pathIndex' => 'bytes12',
'excluded' => 'bool',
),
@ -36,6 +38,7 @@ final class PhabricatorOwnersPath extends PhabricatorOwnersDAO {
$path->pathIndex = PhabricatorHash::digestForIndex($raw_path);
$path->path = $raw_path;
$path->pathDisplay = $raw_path;
$path->excluded = $ref['excluded'];