Clean up some Phame transaction edit bugs

Summary: Ref T12685. Sets required on required fields, cleans up mailtags on PhamePost

Test Plan: Create a new blog, post.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12685

Differential Revision: https://secure.phabricator.com/D17850

src/applications/phame/editor/PhameBlogEditEngine.php

@@ -76,6 +76,7 @@ final class PhameBlogEditEngine
         ->setConduitDescription(pht('Retitle the blog.'))
         ->setConduitTypeDescription(pht('New blog title.'))
         ->setTransactionType(PhameBlogNameTransaction::TRANSACTIONTYPE)
+        ->setIsRequired(true)
         ->setValue($object->getName()),
       id(new PhabricatorTextEditField())
         ->setKey('subtitle')

src/applications/phame/editor/PhamePostEditEngine.php

@@ -98,6 +98,7 @@ final class PhamePostEditEngine
         ->setConduitDescription(pht('Retitle the post.'))
         ->setConduitTypeDescription(pht('New post title.'))
         ->setTransactionType(PhamePostTitleTransaction::TRANSACTIONTYPE)
+        ->setIsRequired(true)
         ->setValue($object->getTitle()),
       id(new PhabricatorTextEditField())
         ->setKey('subtitle')

src/applications/phame/storage/PhamePostTransaction.php

@@ -34,9 +34,9 @@ final class PhamePostTransaction
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         $tags[] = self::MAILTAG_SUBSCRIBERS;
         break;
-      case self::TYPE_TITLE:
+      case PhamePostTitleTransaction::TRANSACTIONTYPE:
-      case self::TYPE_SUBTITLE:
+      case PhamePostSubtitleTransaction::TRANSACTIONTYPE:
-      case self::TYPE_BODY:
+      case PhamePostBodyTransaction::TRANSACTIONTYPE:
         $tags[] = self::MAILTAG_CONTENT;
         break;
       default: