From ae7dc8b9d2ca368df1c5e79b76114af53c47fc18 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 9 Feb 2015 13:10:56 -0800 Subject: [PATCH] Add getGroup to ConfigOptions Summary: Adds core and apps grouping to configuration options, makes it somewhat easier to browse config options. Test Plan: Set each option, review list. Breakdown is nearly 50/50 apps/core. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11722 --- src/__phutil_library_map__.php | 2 +- .../PhabricatorConfigListController.php | 30 ++++++++++++------- .../option/PhabricatorAWSConfigOptions.php | 4 +++ .../PhabricatorAccessLogConfigOptions.php | 4 +++ ...PhabricatorAuthenticationConfigOptions.php | 4 +++ .../PhabricatorClusterConfigOptions.php | 4 +++ .../option/PhabricatorCoreConfigOptions.php | 4 +++ .../PhabricatorDeveloperConfigOptions.php | 4 +++ .../option/PhabricatorDisqusConfigOptions.php | 4 +++ ...catorExtendingPhabricatorConfigOptions.php | 4 +++ ...abricatorGarbageCollectorConfigOptions.php | 4 +++ .../PhabricatorMailgunConfigOptions.php | 4 +++ .../PhabricatorMetaMTAConfigOptions.php | 4 +++ .../option/PhabricatorMySQLConfigOptions.php | 4 +++ .../PhabricatorNotificationConfigOptions.php | 4 +++ .../option/PhabricatorPHDConfigOptions.php | 4 +++ .../PhabricatorPHPMailerConfigOptions.php | 4 +++ .../PhabricatorRecaptchaConfigOptions.php | 4 +++ .../option/PhabricatorSMSConfigOptions.php | 4 +++ .../PhabricatorSecurityConfigOptions.php | 4 +++ .../PhabricatorSendGridConfigOptions.php | 4 +++ ...ricatorSyntaxHighlightingConfigOptions.php | 4 +++ .../PhabricatorTranslationsConfigOptions.php | 4 +++ .../option/PhabricatorUIConfigOptions.php | 4 +++ .../config/ConpherenceConfigOptions.php | 4 +++ .../PhabricatorDifferentialConfigOptions.php | 4 +++ .../PhabricatorDiffusionConfigOptions.php | 4 +++ .../option/PhabricatorAsanaConfigOptions.php | 4 +++ .../config/PhabricatorFeedConfigOptions.php | 4 +++ .../config/PhabricatorFilesConfigOptions.php | 4 +++ .../PhabricatorHarbormasterConfigOptions.php | 4 +++ .../PhabricatorLegalpadConfigOptions.php | 4 +++ .../config/PhabricatorMacroConfigOptions.php | 4 +++ .../PhabricatorManiphestConfigOptions.php | 4 +++ .../config/PhabricatorOwnersConfigOptions.php | 4 +++ .../config/PhabricatorPasteConfigOptions.php | 4 +++ .../config/PhabricatorUserConfigOptions.php | 4 +++ .../config/PhabricatorPhameConfigOptions.php | 4 +++ .../config/PhabricatorPholioConfigOptions.php | 4 +++ .../PhabricatorPhrequentConfigOptions.php | 4 +++ .../PhabricatorPhrictionConfigOptions.php | 4 +++ .../config/PhabricatorPolicyConfigOptions.php | 4 +++ .../PhabricatorProjectConfigOptions.php | 4 +++ ...ricatorReleephApplicationConfigOptions.php | 4 +++ .../PhabricatorRepositoryConfigOptions.php | 4 +++ .../config/PhabricatorSearchConfigOptions.php | 4 +++ 46 files changed, 196 insertions(+), 12 deletions(-) rename src/applications/repository/{ => config}/PhabricatorRepositoryConfigOptions.php (94%) diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index 869f386a9c..748fb09904 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -2286,7 +2286,7 @@ phutil_register_library_map(array( 'PhabricatorRepositoryCommitParserWorker' => 'applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php', 'PhabricatorRepositoryCommitRef' => 'applications/repository/engine/PhabricatorRepositoryCommitRef.php', 'PhabricatorRepositoryCommitSearchIndexer' => 'applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php', - 'PhabricatorRepositoryConfigOptions' => 'applications/repository/PhabricatorRepositoryConfigOptions.php', + 'PhabricatorRepositoryConfigOptions' => 'applications/repository/config/PhabricatorRepositoryConfigOptions.php', 'PhabricatorRepositoryController' => 'applications/repository/controller/PhabricatorRepositoryController.php', 'PhabricatorRepositoryDAO' => 'applications/repository/storage/PhabricatorRepositoryDAO.php', 'PhabricatorRepositoryDiscoveryEngine' => 'applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php', diff --git a/src/applications/config/controller/PhabricatorConfigListController.php b/src/applications/config/controller/PhabricatorConfigListController.php index 6978d21652..4044fa8db3 100644 --- a/src/applications/config/controller/PhabricatorConfigListController.php +++ b/src/applications/config/controller/PhabricatorConfigListController.php @@ -11,17 +11,23 @@ final class PhabricatorConfigListController $nav->selectFilter('/'); $groups = PhabricatorApplicationConfigOptions::loadAll(); - $list = $this->buildConfigOptionsList($groups); + $core_list = $this->buildConfigOptionsList($groups, 'core'); + $apps_list = $this->buildConfigOptionsList($groups, 'apps'); $title = pht('Phabricator Configuration'); - $box = id(new PHUIObjectBoxView()) + $core = id(new PHUIObjectBoxView()) ->setHeaderText($title) - ->appendChild($list); + ->appendChild($core_list); + + $apps = id(new PHUIObjectBoxView()) + ->setHeaderText(pht('Applications Configuration')) + ->appendChild($apps_list); $nav->appendChild( array( - $box, + $core, + $apps, )); $crumbs = $this @@ -37,19 +43,21 @@ final class PhabricatorConfigListController )); } - private function buildConfigOptionsList(array $groups) { + private function buildConfigOptionsList(array $groups, $type) { assert_instances_of($groups, 'PhabricatorApplicationConfigOptions'); $list = new PHUIObjectItemListView(); $list->setStackable(true); $groups = msort($groups, 'getName'); foreach ($groups as $group) { - $item = id(new PHUIObjectItemView()) - ->setHeader($group->getName()) - ->setHref('/config/group/'.$group->getKey().'/') - ->addAttribute($group->getDescription()) - ->setFontIcon($group->getFontIcon()); - $list->addItem($item); + if ($group->getGroup() == $type) { + $item = id(new PHUIObjectItemView()) + ->setHeader($group->getName()) + ->setHref('/config/group/'.$group->getKey().'/') + ->addAttribute($group->getDescription()) + ->setFontIcon($group->getFontIcon()); + $list->addItem($item); + } } return $list; diff --git a/src/applications/config/option/PhabricatorAWSConfigOptions.php b/src/applications/config/option/PhabricatorAWSConfigOptions.php index 6d43077f10..87b663c835 100644 --- a/src/applications/config/option/PhabricatorAWSConfigOptions.php +++ b/src/applications/config/option/PhabricatorAWSConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorAWSConfigOptions return 'fa-server'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('amazon-ses.access-key', 'string', null) diff --git a/src/applications/config/option/PhabricatorAccessLogConfigOptions.php b/src/applications/config/option/PhabricatorAccessLogConfigOptions.php index 6c645247e0..c186fc3557 100644 --- a/src/applications/config/option/PhabricatorAccessLogConfigOptions.php +++ b/src/applications/config/option/PhabricatorAccessLogConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorAccessLogConfigOptions return 'fa-list'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { $common_map = array( 'C' => pht('The controller or workflow which handled the request.'), diff --git a/src/applications/config/option/PhabricatorAuthenticationConfigOptions.php b/src/applications/config/option/PhabricatorAuthenticationConfigOptions.php index 2aa2fc5199..dc7996a3ee 100644 --- a/src/applications/config/option/PhabricatorAuthenticationConfigOptions.php +++ b/src/applications/config/option/PhabricatorAuthenticationConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorAuthenticationConfigOptions return 'fa-key'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('auth.require-email-verification', 'bool', false) diff --git a/src/applications/config/option/PhabricatorClusterConfigOptions.php b/src/applications/config/option/PhabricatorClusterConfigOptions.php index 4ac6bc9acc..f6e2849e43 100644 --- a/src/applications/config/option/PhabricatorClusterConfigOptions.php +++ b/src/applications/config/option/PhabricatorClusterConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorClusterConfigOptions return 'fa-sitemap'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('cluster.addresses', 'list', array()) diff --git a/src/applications/config/option/PhabricatorCoreConfigOptions.php b/src/applications/config/option/PhabricatorCoreConfigOptions.php index c8dbbc73ea..189ba30607 100644 --- a/src/applications/config/option/PhabricatorCoreConfigOptions.php +++ b/src/applications/config/option/PhabricatorCoreConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorCoreConfigOptions return 'fa-bullseye'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { if (phutil_is_windows()) { $paths = array(); diff --git a/src/applications/config/option/PhabricatorDeveloperConfigOptions.php b/src/applications/config/option/PhabricatorDeveloperConfigOptions.php index b70c1067ac..665c38e0bd 100644 --- a/src/applications/config/option/PhabricatorDeveloperConfigOptions.php +++ b/src/applications/config/option/PhabricatorDeveloperConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorDeveloperConfigOptions return 'fa-bug'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('darkconsole.enabled', 'bool', false) diff --git a/src/applications/config/option/PhabricatorDisqusConfigOptions.php b/src/applications/config/option/PhabricatorDisqusConfigOptions.php index 1c69f2e838..9bc6e13e39 100644 --- a/src/applications/config/option/PhabricatorDisqusConfigOptions.php +++ b/src/applications/config/option/PhabricatorDisqusConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorDisqusConfigOptions return 'fa-comment'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('disqus.shortname', 'string', null) diff --git a/src/applications/config/option/PhabricatorExtendingPhabricatorConfigOptions.php b/src/applications/config/option/PhabricatorExtendingPhabricatorConfigOptions.php index 708fb23feb..ef07bc9109 100644 --- a/src/applications/config/option/PhabricatorExtendingPhabricatorConfigOptions.php +++ b/src/applications/config/option/PhabricatorExtendingPhabricatorConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorExtendingPhabricatorConfigOptions return 'fa-rocket'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('load-libraries', 'list', array()) diff --git a/src/applications/config/option/PhabricatorGarbageCollectorConfigOptions.php b/src/applications/config/option/PhabricatorGarbageCollectorConfigOptions.php index d54020d694..c1095d1520 100644 --- a/src/applications/config/option/PhabricatorGarbageCollectorConfigOptions.php +++ b/src/applications/config/option/PhabricatorGarbageCollectorConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorGarbageCollectorConfigOptions return 'fa-trash-o'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { $options = array( diff --git a/src/applications/config/option/PhabricatorMailgunConfigOptions.php b/src/applications/config/option/PhabricatorMailgunConfigOptions.php index 55d9398ac7..3f7fbf576a 100644 --- a/src/applications/config/option/PhabricatorMailgunConfigOptions.php +++ b/src/applications/config/option/PhabricatorMailgunConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorMailgunConfigOptions return 'fa-send-o'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('mailgun.domain', 'string', null) diff --git a/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php b/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php index 46769ee216..fb4667a0ff 100644 --- a/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php +++ b/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorMetaMTAConfigOptions return 'fa-send'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { $send_as_user_desc = $this->deformat(pht(<<newOption('mysql.host', 'string', 'localhost') diff --git a/src/applications/config/option/PhabricatorNotificationConfigOptions.php b/src/applications/config/option/PhabricatorNotificationConfigOptions.php index 4bf1e0a142..f43f2af32a 100644 --- a/src/applications/config/option/PhabricatorNotificationConfigOptions.php +++ b/src/applications/config/option/PhabricatorNotificationConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorNotificationConfigOptions return 'fa-bell'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('notification.enabled', 'bool', false) diff --git a/src/applications/config/option/PhabricatorPHDConfigOptions.php b/src/applications/config/option/PhabricatorPHDConfigOptions.php index 36913ceb45..ee240d3916 100644 --- a/src/applications/config/option/PhabricatorPHDConfigOptions.php +++ b/src/applications/config/option/PhabricatorPHDConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorPHDConfigOptions return 'fa-pied-piper-alt'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('phd.pid-directory', 'string', '/var/tmp/phd/pid') diff --git a/src/applications/config/option/PhabricatorPHPMailerConfigOptions.php b/src/applications/config/option/PhabricatorPHPMailerConfigOptions.php index c630b172aa..3828ac1c03 100644 --- a/src/applications/config/option/PhabricatorPHPMailerConfigOptions.php +++ b/src/applications/config/option/PhabricatorPHPMailerConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorPHPMailerConfigOptions return 'fa-send-o'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('phpmailer.mailer', 'string', 'smtp') diff --git a/src/applications/config/option/PhabricatorRecaptchaConfigOptions.php b/src/applications/config/option/PhabricatorRecaptchaConfigOptions.php index 061fe8695c..d35820c51d 100644 --- a/src/applications/config/option/PhabricatorRecaptchaConfigOptions.php +++ b/src/applications/config/option/PhabricatorRecaptchaConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorRecaptchaConfigOptions return 'fa-recycle'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( diff --git a/src/applications/config/option/PhabricatorSMSConfigOptions.php b/src/applications/config/option/PhabricatorSMSConfigOptions.php index bfe1ccfa55..60a8e2402c 100644 --- a/src/applications/config/option/PhabricatorSMSConfigOptions.php +++ b/src/applications/config/option/PhabricatorSMSConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorSMSConfigOptions return 'fa-mobile'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { $adapter_description = $this->deformat(pht(<<newOption('sendgrid.api-user', 'string', null) diff --git a/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php b/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php index a3ec76758d..cffb2a82bf 100644 --- a/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php +++ b/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorSyntaxHighlightingConfigOptions return 'fa-code'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { $caches_href = PhabricatorEnv::getDocLink('Managing Caches'); diff --git a/src/applications/config/option/PhabricatorTranslationsConfigOptions.php b/src/applications/config/option/PhabricatorTranslationsConfigOptions.php index 3728848756..57d86c3844 100644 --- a/src/applications/config/option/PhabricatorTranslationsConfigOptions.php +++ b/src/applications/config/option/PhabricatorTranslationsConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorTranslationsConfigOptions return 'fa-globe'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption( diff --git a/src/applications/config/option/PhabricatorUIConfigOptions.php b/src/applications/config/option/PhabricatorUIConfigOptions.php index ee0554a7b0..dcb2de3cf9 100644 --- a/src/applications/config/option/PhabricatorUIConfigOptions.php +++ b/src/applications/config/option/PhabricatorUIConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorUIConfigOptions return 'fa-magnet'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { $manifest = PHUIIconView::getSheetManifest('main-header'); diff --git a/src/applications/conpherence/config/ConpherenceConfigOptions.php b/src/applications/conpherence/config/ConpherenceConfigOptions.php index e8759e931d..f309b8d569 100644 --- a/src/applications/conpherence/config/ConpherenceConfigOptions.php +++ b/src/applications/conpherence/config/ConpherenceConfigOptions.php @@ -15,6 +15,10 @@ final class ConpherenceConfigOptions return 'fa-comments'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption( diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php index 5ef299fdb5..ed16005a26 100644 --- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php +++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorDifferentialConfigOptions return 'fa-cog'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { $custom_field_type = 'custom:PhabricatorCustomFieldConfigOptionType'; diff --git a/src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php b/src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php index 60dd0b191b..33fed25b51 100644 --- a/src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php +++ b/src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorDiffusionConfigOptions return 'fa-code'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption( diff --git a/src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php b/src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php index f8e6257a11..5adf6725e9 100644 --- a/src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php +++ b/src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorAsanaConfigOptions return 'fa-exchange'; } + public function getGroup() { + return 'core'; + } + public function getOptions() { return array( $this->newOption('asana.workspace-id', 'string', null) diff --git a/src/applications/feed/config/PhabricatorFeedConfigOptions.php b/src/applications/feed/config/PhabricatorFeedConfigOptions.php index 4814864b4b..2ee6a7bcaf 100644 --- a/src/applications/feed/config/PhabricatorFeedConfigOptions.php +++ b/src/applications/feed/config/PhabricatorFeedConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorFeedConfigOptions return 'fa-newspaper-o'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption('feed.public', 'bool', false) diff --git a/src/applications/files/config/PhabricatorFilesConfigOptions.php b/src/applications/files/config/PhabricatorFilesConfigOptions.php index 1c00cd581e..bcc987c9cb 100644 --- a/src/applications/files/config/PhabricatorFilesConfigOptions.php +++ b/src/applications/files/config/PhabricatorFilesConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorFilesConfigOptions return 'fa-file'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { $viewable_default = array( 'image/jpeg' => 'image/jpeg', diff --git a/src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php b/src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php index d9a49c11ff..0471984dbc 100644 --- a/src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php +++ b/src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorHarbormasterConfigOptions return 'fa-ship'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array(); } diff --git a/src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php b/src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php index d804c0d9e0..e88ecb98f1 100644 --- a/src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php +++ b/src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorLegalpadConfigOptions return 'fa-gavel'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption( diff --git a/src/applications/macro/config/PhabricatorMacroConfigOptions.php b/src/applications/macro/config/PhabricatorMacroConfigOptions.php index 31275800aa..7da3688f9d 100644 --- a/src/applications/macro/config/PhabricatorMacroConfigOptions.php +++ b/src/applications/macro/config/PhabricatorMacroConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorMacroConfigOptions return 'fa-file-image-o'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption('metamta.macro.reply-handler-domain', 'string', null) diff --git a/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php b/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php index 70249ce079..acd980b1ed 100644 --- a/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php +++ b/src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorManiphestConfigOptions return 'fa-anchor'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { $priority_defaults = array( diff --git a/src/applications/owners/config/PhabricatorOwnersConfigOptions.php b/src/applications/owners/config/PhabricatorOwnersConfigOptions.php index ddfec7c306..7bf24607b5 100644 --- a/src/applications/owners/config/PhabricatorOwnersConfigOptions.php +++ b/src/applications/owners/config/PhabricatorOwnersConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorOwnersConfigOptions return 'fa-gift'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption( diff --git a/src/applications/paste/config/PhabricatorPasteConfigOptions.php b/src/applications/paste/config/PhabricatorPasteConfigOptions.php index bb2a3c6996..e12fdc954d 100644 --- a/src/applications/paste/config/PhabricatorPasteConfigOptions.php +++ b/src/applications/paste/config/PhabricatorPasteConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorPasteConfigOptions return 'fa-paste'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption( diff --git a/src/applications/people/config/PhabricatorUserConfigOptions.php b/src/applications/people/config/PhabricatorUserConfigOptions.php index f1478787eb..afd1d376a0 100644 --- a/src/applications/people/config/PhabricatorUserConfigOptions.php +++ b/src/applications/people/config/PhabricatorUserConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorUserConfigOptions return 'fa-users'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { $default = array( diff --git a/src/applications/phame/config/PhabricatorPhameConfigOptions.php b/src/applications/phame/config/PhabricatorPhameConfigOptions.php index 3ba1644086..71dd8ee1c9 100644 --- a/src/applications/phame/config/PhabricatorPhameConfigOptions.php +++ b/src/applications/phame/config/PhabricatorPhameConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorPhameConfigOptions return 'fa-star'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption( diff --git a/src/applications/pholio/config/PhabricatorPholioConfigOptions.php b/src/applications/pholio/config/PhabricatorPholioConfigOptions.php index f2116221ec..44a8b36220 100644 --- a/src/applications/pholio/config/PhabricatorPholioConfigOptions.php +++ b/src/applications/pholio/config/PhabricatorPholioConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorPholioConfigOptions return 'fa-camera-retro'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption('metamta.pholio.reply-handler-domain', 'string', null) diff --git a/src/applications/phrequent/config/PhabricatorPhrequentConfigOptions.php b/src/applications/phrequent/config/PhabricatorPhrequentConfigOptions.php index b24b4414f1..a6113155a9 100644 --- a/src/applications/phrequent/config/PhabricatorPhrequentConfigOptions.php +++ b/src/applications/phrequent/config/PhabricatorPhrequentConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorPhrequentConfigOptions return 'fa-clock-o'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array(); } diff --git a/src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php b/src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php index b5fc176470..7e6080dd7c 100644 --- a/src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php +++ b/src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorPhrictionConfigOptions return 'fa-book'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption( diff --git a/src/applications/policy/config/PhabricatorPolicyConfigOptions.php b/src/applications/policy/config/PhabricatorPolicyConfigOptions.php index e13da65f63..d629b5b370 100644 --- a/src/applications/policy/config/PhabricatorPolicyConfigOptions.php +++ b/src/applications/policy/config/PhabricatorPolicyConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorPolicyConfigOptions return 'fa-lock'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { $policy_locked_type = 'custom:PolicyLockOptionType'; $policy_locked_example = array( diff --git a/src/applications/project/config/PhabricatorProjectConfigOptions.php b/src/applications/project/config/PhabricatorProjectConfigOptions.php index 546cf2d621..8ec8bc8607 100644 --- a/src/applications/project/config/PhabricatorProjectConfigOptions.php +++ b/src/applications/project/config/PhabricatorProjectConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorProjectConfigOptions return 'fa-briefcase'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { $default_fields = array( 'std:project:internal:description' => true, diff --git a/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php b/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php index 4bd0df2638..86f78a48fe 100644 --- a/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php +++ b/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorReleephApplicationConfigOptions return 'fa-flag-checkered'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { $default_fields = array( new ReleephSummaryFieldSpecification(), diff --git a/src/applications/repository/PhabricatorRepositoryConfigOptions.php b/src/applications/repository/config/PhabricatorRepositoryConfigOptions.php similarity index 94% rename from src/applications/repository/PhabricatorRepositoryConfigOptions.php rename to src/applications/repository/config/PhabricatorRepositoryConfigOptions.php index f8fbef86c2..fa8e38e063 100644 --- a/src/applications/repository/PhabricatorRepositoryConfigOptions.php +++ b/src/applications/repository/config/PhabricatorRepositoryConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorRepositoryConfigOptions return 'fa-hdd-o'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption('repository.default-local-path', 'string', '/var/repo/') diff --git a/src/applications/search/config/PhabricatorSearchConfigOptions.php b/src/applications/search/config/PhabricatorSearchConfigOptions.php index a3554ff482..f8cb143b94 100644 --- a/src/applications/search/config/PhabricatorSearchConfigOptions.php +++ b/src/applications/search/config/PhabricatorSearchConfigOptions.php @@ -15,6 +15,10 @@ final class PhabricatorSearchConfigOptions return 'fa-search'; } + public function getGroup() { + return 'apps'; + } + public function getOptions() { return array( $this->newOption(