Explicitly list reviewers on reviewrequest email

Summary: This used to be in the subject but there was a bunch of churn and now
it's nowhere.
Test Plan: Created, updated, and added CCs to a diff.
Reviewed By: moskov
Reviewers: moskov, avitaloliver, jungejason, tuomaspelkonen, aran
CC: aran, moskov
Differential Revision: 567

src/applications/differential/mail/base/DifferentialMail.php

@@ -319,4 +319,12 @@ EOTEXT;
     return $this->heraldTranscriptURI;
   }
 
+  protected function renderHandleList(array $handles, array $phids) {
+    $names = array();
+    foreach ($phids as $phid) {
+      $names[] = $handles[$phid]->getName();
+    }
+    return implode(', ', $names);
+  }
+
 }

src/applications/differential/mail/ccwelcome/DifferentialCCWelcomeMail.php

@@ -30,6 +30,7 @@ class DifferentialCCWelcomeMail extends DifferentialReviewRequestMail {
     $body = array();
 
     $body[] = "{$actor} added you to the CC list for the revision \"{$name}\".";
+    $body[] = $this->renderReviewersLine();
     $body[] = null;
 
     $body[] = $this->renderReviewRequestBody();

src/applications/differential/mail/comment/DifferentialCommentMail.php

@@ -160,12 +160,4 @@ class DifferentialCommentMail extends DifferentialMail {
 
     return implode("\n", $body);
   }
-
-  private function renderHandleList(array $handles, array $phids) {
-    $names = array();
-    foreach ($phids as $phid) {
-      $names[] = $handles[$phid]->getName();
-    }
-    return implode(', ', $names);
-  }
 }

src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php

@@ -58,6 +58,7 @@ class DifferentialNewDiffMail extends DifferentialReviewRequestMail {
     } else {
       $body[] = "{$actor} updated the revision \"{$name}\".";
     }
+    $body[] = $this->renderReviewersLine();
     $body[] = null;
 
     $body[] = $this->renderReviewRequestBody();

src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php

@@ -39,6 +39,12 @@ abstract class DifferentialReviewRequestMail extends DifferentialMail {
     $this->setChangesets($changesets);
   }
 
+  protected function renderReviewersLine() {
+    $reviewers = $this->getRevision()->getReviewers();
+    $handles = id(new PhabricatorObjectHandleData($reviewers))->loadHandles();
+    return 'Reviewers: '.$this->renderHandleList($handles, $reviewers);
+  }
+
   protected function renderReviewRequestBody() {
     $revision = $this->getRevision();
 

src/applications/differential/mail/reviewrequest/__init__.php

@@ -7,6 +7,9 @@
 
 
 phutil_require_module('phabricator', 'applications/differential/mail/base');
+phutil_require_module('phabricator', 'applications/phid/handle/data');
+
+phutil_require_module('phutil', 'utils');
 
 
 phutil_require_source('DifferentialReviewRequestMail.php');