From af1d494d66e9743dcd89d8a872a31d8e1b71f208 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 11 Apr 2017 09:51:01 -0700 Subject: [PATCH] Fix an issue where rejecting reviewers weren't powerful enough Summary: Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject". Set the "older reject" flag properly when we find a non-current reject. Test Plan: - User A accepts a revision. - User B rejects it. - Author updates it. - Before patch: incorrectly transitions to "accepted" ("older" reject is ignored). - After patch: correctly transitions to "needs review". Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D17653 --- .../differential/editor/DifferentialTransactionEditor.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php index dd6666c653..0086c101e2 100644 --- a/src/applications/differential/editor/DifferentialTransactionEditor.php +++ b/src/applications/differential/editor/DifferentialTransactionEditor.php @@ -672,6 +672,8 @@ final class DifferentialTransactionEditor $active_phid = $active_diff->getPHID(); if ($reviewer->isRejected($active_phid)) { $has_rejecting_reviewer = true; + } else { + $has_rejecting_older_reviewer = true; } break; case DifferentialReviewerStatus::STATUS_REJECTED_OLDER: